From owner-svn-src-head@FreeBSD.ORG Fri Feb 24 00:01:03 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6405A106564A for ; Fri, 24 Feb 2012 00:01:03 +0000 (UTC) (envelope-from andy@fud.org.nz) Received: from mail-pw0-f54.google.com (mail-pw0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 376578FC0C for ; Fri, 24 Feb 2012 00:01:03 +0000 (UTC) Received: by pbcxa7 with SMTP id xa7so2169727pbc.13 for ; Thu, 23 Feb 2012 16:01:02 -0800 (PST) Received-SPF: pass (google.com: domain of andy@fud.org.nz designates 10.68.73.97 as permitted sender) client-ip=10.68.73.97; Authentication-Results: mr.google.com; spf=pass (google.com: domain of andy@fud.org.nz designates 10.68.73.97 as permitted sender) smtp.mail=andy@fud.org.nz Received: from mr.google.com ([10.68.73.97]) by 10.68.73.97 with SMTP id k1mr721791pbv.61.1330041662984 (num_hops = 1); Thu, 23 Feb 2012 16:01:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.73.97 with SMTP id k1mr440557pbv.61.1330040324513; Thu, 23 Feb 2012 15:38:44 -0800 (PST) Sender: andy@fud.org.nz Received: by 10.68.2.229 with HTTP; Thu, 23 Feb 2012 15:38:44 -0800 (PST) In-Reply-To: <4F46CA60.6030409@FreeBSD.org> References: <201202232156.q1NLurPU025054@svn.freebsd.org> <4F46CA60.6030409@FreeBSD.org> Date: Fri, 24 Feb 2012 12:38:44 +1300 X-Google-Sender-Auth: TJEFVLDLwu0lJn1D2rQ5ZhWuYro Message-ID: From: Andrew Thompson To: Doug Barton Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Gm-Message-State: ALoCoQn+iAjlqFMU41x0o6+lLcOzoYEMfLDNGxrfy2rWzjGAQOcm7+zjy2P2L96jNEJ1GzA6LdIT Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r232080 - in head: share/man/man4 sys/net X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2012 00:01:03 -0000 On 24 February 2012 12:23, Doug Barton wrote: > First, I'm always glad to see devs updating the documentation, so please > don't take this as in any way being critical, just trying to help. :) n/p, I like feedback. > On 02/23/2012 13:56, Andrew Thompson wrote: >> Modified: head/share/man/man4/lagg.4 >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/share/man/man4/lagg.4 =A0 =A0 =A0 =A0Thu Feb 23 21:54:04 2012 = =A0 =A0 =A0 =A0(r232079) >> +++ head/share/man/man4/lagg.4 =A0 =A0 =A0 =A0Thu Feb 23 21:56:53 2012 = =A0 =A0 =A0 =A0(r232080) >> @@ -142,10 +142,12 @@ and >> =A0modes will use the RSS hash from the network card if available to avo= id >> =A0computing one, this may give poor traffic distribution if the hash is= invalid >> =A0or uses less of the protocol header information. >> -Local hash computation can be forced by setting the >> +Local hash computation can be forced per interface by setting the > > This is a great example of why we use short lines in the man page > sources. It allows people to come along later and add text without > having to make changes to multiple lines. I can see your point here. >> =A0.Va net.link.lagg.X.use_flowid >> =A0.Xr sysctl 8 >> -variable to zero where X is the interface number. >> +variable to zero where X is the interface number, the default for >> +new interfaces is set via >> +.Va net.link.lagg.default_use_flowid . > > If adding a comma there was the right change the new clause should still > have started on the next line, for the reason described above. However, > what you added is actually a sentence that can/should stand on its own. Fixed. Andrew