From owner-svn-src-head@FreeBSD.ORG Thu Jul 1 07:56:14 2010 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 09AC0106564A; Thu, 1 Jul 2010 07:56:14 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117]) by mx1.freebsd.org (Postfix) with ESMTP id 635718FC1B; Thu, 1 Jul 2010 07:56:12 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.4/8.14.4) with ESMTP id o617uBn8072152; Thu, 1 Jul 2010 11:56:11 +0400 (MSD) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.4/8.14.4/Submit) id o617uBKV072151; Thu, 1 Jul 2010 11:56:11 +0400 (MSD) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Thu, 1 Jul 2010 11:56:11 +0400 From: Gleb Smirnoff To: Jack Vogel Message-ID: <20100701075611.GG63689@FreeBSD.org> References: <201007010503.o6153O78066276@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r209622 - head/sys/dev/ixgbe X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jul 2010 07:56:14 -0000 Jack, On Wed, Jun 30, 2010 at 10:09:22PM -0700, Jack Vogel wrote: J> I went to a LOT of trouble setting up a mirror at home and just as I went to J> commit J> the change its updated. J> J> While I understand the good intentions, please don't do this again. If I had J> been J> unresponsive for days or something I understand, but its been hours, and I J> was J> fixing it. We can't forecast future. Yesterday, I couldn't tell whether you will be unresponsive for days or for hours. Do you propose a policy to wait for days before putting an obvious fix? Live for days with a broken build? Waste peoples time, receive mails from tinderbox, receive mails on current@ from real people? Every time you^Wsomeone breaks build, a lot of manhours are wasted. Dozens of developers encounter breakage and spend their time on fixing it in their working trees. Not mentioning common FreeBSD users, who are brave enough to run CURRENT. If the first committer, who encountered the breakage, commits a fix, then a lot of manhours are saved, avoiding all others doing this job for their own trees. And the breakage passes by almost unnoticed. So, anytime I update sources and encounter an obvious error, I WILL FIX IT, to save time of other people, since I respect time of other people. And you do not, because you never do even a simple test build of changes you commit, not speaking about run tests. Skipping these important steps, you save your own time, for the price of other peoples time in the order of magnitude. Look at the commit history of your drivers: every second check in, or even more often, either build is broken, or some important change is backed out, or functionality of the driver is broken. Don't you think you should do more testing before checking in? -- Totus tuus, Glebius.