From owner-freebsd-commit Sun Aug 13 15:44:16 1995 Return-Path: commit-owner Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id PAA10016 for commit-outgoing; Sun, 13 Aug 1995 15:44:16 -0700 Received: (from majordom@localhost) by freefall.FreeBSD.org (8.6.11/8.6.6) id PAA10003 for cvs-usrsbin-outgoing; Sun, 13 Aug 1995 15:44:13 -0700 Received: from gndrsh.aac.dev.com (gndrsh.aac.dev.com [198.145.92.241]) by freefall.FreeBSD.org (8.6.11/8.6.6) with ESMTP id PAA09992 ; Sun, 13 Aug 1995 15:44:09 -0700 Received: (from rgrimes@localhost) by gndrsh.aac.dev.com (8.6.11/8.6.9) id PAA11367; Sun, 13 Aug 1995 15:43:38 -0700 From: "Rodney W. Grimes" Message-Id: <199508132243.PAA11367@gndrsh.aac.dev.com> Subject: Re: cvs commit: src/usr.sbin Makefile To: peter@haywire.dialix.com (Peter Wemm) Date: Sun, 13 Aug 1995 15:43:38 -0700 (PDT) Cc: CVS-commiters@freefall.FreeBSD.org, cvs-usrsbin@freefall.FreeBSD.org In-Reply-To: from "Peter Wemm" at Aug 14, 95 06:35:43 am X-Mailer: ELM [version 2.4 PL24] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Length: 2030 Sender: commit-owner@FreeBSD.org Precedence: bulk > > On Sun, 13 Aug 1995, Rodney W. Grimes wrote: > > > peter 95/08/13 08:28:20 > > > > > > Modified: usr.sbin Makefile > > > Log: > > > Add sicontrol.. I hope this is the right way.. > > > > When ever you have to say things like that, please send the patch out > > for review before commiting it. > > Sorry.. that was badly worded and not what I was thinking of... I knew > what I had entered was in line with what everybody else had done, I was > going to make a comment about the ordering in the file being inconsistant > (the cleandir and i386 conditionals had a couple of entries out of > alphabetical order.. no big deal), but Tristan (8 months old) decided that > right that instant that I started the log message was a good time to wake up > and demand a feed (it was about 3am or so, and he's currently rather > unwell), and that's what blurted out while I was distracted.. :-) Understood. > > I didn't want to risk aborting the commit, as some versions of cvs do > stranger things than others.. I couldn't leave it there, as it'd leave > the directory locked for an hour.. So we ended up with a > not-very-confidence-inspiring commit message.. Sorry.. The version of cvs running on freefall will handle a q!, abort operation just fine. I have done it on so many occasions I don't care to count them any more. If we ever do get a version of cvs that fails this, it would be a class A1 bug in my book, meaning fix it today, or as fast as we can. I often get in to the commit, see the CVS: lines are not what I expected and abort the commit to go fix my mistake. [Often cvs add, or cvs remove commands forgotten]. Which reminds me, did you ever get any feedback from the cvs group to that small bug fix for 0 lenght RCS files in the repository? We still need to commit a fix and get a new version of cvs installed on freefall. -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Reliable computers for FreeBSD