From owner-freebsd-ports@FreeBSD.ORG Thu Jan 12 06:49:35 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B22731065688 for ; Thu, 12 Jan 2012 06:49:35 +0000 (UTC) (envelope-from freebsd-ports@herveybayaustralia.com.au) Received: from mail.unitedinsong.com.au (mail.unitedinsong.com.au [150.101.178.33]) by mx1.freebsd.org (Postfix) with ESMTP id 2D3FA8FC2C for ; Thu, 12 Jan 2012 06:49:35 +0000 (UTC) Received: from laptop1.herveybayaustralia.com.au (laptop1.herveybayaustralia.com.au [192.168.0.179]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.unitedinsong.com.au (Postfix) with ESMTPSA id B27205C27 for ; Thu, 12 Jan 2012 17:01:26 +1000 (EST) Message-ID: <4F0E8145.30203@herveybayaustralia.com.au> Date: Thu, 12 Jan 2012 16:44:21 +1000 From: Da Rock User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:7.0.1) Gecko/20111109 Thunderbird/7.0.1 MIME-Version: 1.0 To: freebsd-ports@freebsd.org References: <4F0446B7.4090703@herveybayaustralia.com.au> <20120104142757.1c77c347@ernst.jennejohn.org> <4F04E648.9090206@herveybayaustralia.com.au> <20120105121825.656677e4@ernst.jennejohn.org> <20120106221610.00005fbe@unknown> <20120108160316.00003d59@unknown> <4F0A8164.9090502@herveybayaustralia.com.au> <20120110221115.00007dc1@unknown> <4F0CDB5B.9030402@herveybayaustralia.com.au> <4F0DB794.7000600@infracaninophile.co.uk> In-Reply-To: <4F0DB794.7000600@infracaninophile.co.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: linux-f10-nss_ldap: my first port - be gentle :) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2012 06:49:35 -0000 On 01/12/12 02:23, Matthew Seaman wrote: > On 11/01/2012 16:10, Eitan Adler wrote: >>>> post-extract: >>>>>> .if defined(WITH_PAM) >>>>>> PLIST_FILES+=lib/security/pam_ldap.so >>>>>> >>>>>> >>>>>> .else >>>>>> @if [ -f ${WRKDIR}/lib/security/pam_ldap.so ]; then \ >>>>>> ${RM} ${WRKDIR}/lib/security/pam_ldap.so >>>>>> ${DIRRM} ${WRKDIR}/lib/; >>>>>> fi >>>> ^^^^^ >>>> This is what's wrong. In port Makefiles, it's .if, .else, .endif not fi. >> You need both: .endif and fi in this case (the 'fi' is part of the shell script) > Also the shell script part needs to be backslashed, and statements > separated by semi-colons, like so: > > @if [ -f ${WRKDIR}/lib/security/pam_ldap.so ]; then \ > ${RM} ${WRKDIR}/lib/security/pam_ldap.so ; \ > ${DIRRM} ${WRKDIR}/lib/ ; \ > fi > > Looking back at the OP's previous posts, it's this backslashing thing > which is missing: the (make) .if is properly closed with a .endif, which > unfortunately got cropped in one of the replies upthread. > > Another point: its not usual to modify variables like PLIST_FILES or > PORTDOCS as part of the post-extract target. Usually that's done > earlier in the Makefile before any of the actual make targets. You were right Matthew. It's all done now guys- what now? I have a Makefile, pkg-desc, pkg-plist, pkg-message, distinfo. I also have the files hosted and the MASTER_FILES set to include the linux sites (just where the files are located). I am looking for a backup site to all that IF I can twist someones arm? I have triple tested it all in all iterations and its as smooth as now- no issues whatsoever. So what happens now? How does it get into the ports tree now? Can someone have a look see and test it before I submit this thing? As for the bsd.sites question: before I posted this I navigated to the sites in question, and they had messages to redirect to this URI that I have posted. As for my own files, I can use release, updates, or testing. ATM its set to the testing files. Should I back that off a bit? I set the portversion to the nss_ldap_version (264). What about the 6 do you think? It could be trickier... The Makefile has lost weight - I trimmed it aggressively, but if I can cut it back further I'd be happy to know. I've posted the shar to http://herveybayaustralia.com.au/ports/distfiles/linux-f10-nss_ldap.shar if people want to check it out. Please don't hold back if there is something I've missed. I have a query on the tabbing - I have either ee or gedit (atm) how can I set them to the correct tab spacing? Cheers