From owner-freebsd-net Tue Jul 30 10:15:40 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA09537B400 for ; Tue, 30 Jul 2002 10:15:37 -0700 (PDT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6FCAA43E42 for ; Tue, 30 Jul 2002 10:15:37 -0700 (PDT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (IDENT:brdavis@localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.12.3/8.12.3) with ESMTP id g6UHFXpO030620; Tue, 30 Jul 2002 10:15:33 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.12.3/8.12.3/Submit) id g6UHFX22030619; Tue, 30 Jul 2002 10:15:33 -0700 Date: Tue, 30 Jul 2002 10:15:33 -0700 From: Brooks Davis To: "M. Warner Losh" Cc: brooks@one-eyed-alien.net, net@FreeBSD.ORG Subject: Re: switching to if_xname from if_name and if_unit Message-ID: <20020730101533.A29988@Odin.AC.HMC.Edu> References: <20020726211050.A30598@Odin.AC.HMC.Edu> <20020729.223834.32171634.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX" Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20020729.223834.32171634.imp@bsdimp.com>; from imp@bsdimp.com on Mon, Jul 29, 2002 at 10:38:34PM -0600 X-Virus-Scanned: by amavisd-milter (http://amavis.org/) on odin.ac.hmc.edu Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org --huq684BweRXVnRxX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 29, 2002 at 10:38:34PM -0600, M. Warner Losh wrote: > : @@ -280,8 +280,7 @@ ep_attach(sc) > : attached =3D (ifp->if_softc !=3D 0); > : =20 > : ifp->if_softc =3D sc; > : - ifp->if_unit =3D sc->unit; > : - ifp->if_name =3D "ep"; > : + sprintf(ifp->if_xname, "ep%d", sc->unit); >=20 > strcpy(ifp->if_xname, device_get_name(sc->dev)); >=20 > might be better, don't you think? Yes, that's probably better. At least it's one less place that needs to know the name of the device. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --huq684BweRXVnRxX Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (GNU/Linux) Comment: For info see http://www.gnupg.org iD8DBQE9Rsm0XY6L6fI4GtQRAhSCAKCUyjQjEctl0Xgn6WlQf4uh+bNqpACaA6QT haiG0YZwLF8zgxWWb+hyDfc= =p7Ge -----END PGP SIGNATURE----- --huq684BweRXVnRxX-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message