From owner-cvs-ports@FreeBSD.ORG Tue Mar 24 02:17:51 2009 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CFE461065672 for ; Tue, 24 Mar 2009 02:17:51 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with ESMTP id 73D888FC15 for ; Tue, 24 Mar 2009 02:17:51 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 4005 invoked by uid 399); 24 Mar 2009 02:17:49 -0000 Received: from localhost (HELO lap.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 24 Mar 2009 02:17:49 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <49C842CB.6070900@FreeBSD.org> Date: Mon, 23 Mar 2009 19:17:47 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.21 (X11/20090321) MIME-Version: 1.0 To: obrien@freebsd.org References: <200903120954.n2C9s2ev063133@repoman.freebsd.org> <20090313023956.GA49511@dragon.NUXI.org> <49BA52D2.8090209@FreeBSD.org> <20090323231412.GA94221@hub.freebsd.org> In-Reply-To: <20090323231412.GA94221@hub.freebsd.org> X-Enigmail-Version: 0.95.7 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-ports@FreeBSD.org, Pav Lucistnik , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/shells/bash Makefile pkg-plist X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Mar 2009 02:17:52 -0000 David O'Brien wrote: > On Fri, Mar 13, 2009 at 01:34:26PM +0100, Pav Lucistnik wrote: >> David O'Brien wrote: >>> On Thu, Mar 12, 2009 at 09:54:01AM +0000, Sergey A. Osokin wrote: >>>> osa 2009-03-12 09:54:01 UTC >>>> FreeBSD ports repository >>>> Modified files: >>>> shells/bash Makefile pkg-plist >>>> Log: >>>> Fix pkg-plist. >>>> Bump PORTREVISION. >>> Thanks for fixing the PLIST (much appreciated), but why did you bump >>> PORTREVISION for a PLIST change? >>> >>> There is zero reason to force a reinstall for a PLIST change. Either the >>> port is already installed (and the user can wait for some other reason to >>> update), or the port isn't installed and bumping PORTREVISION does >>> nothing. Actually if you bump PORTREVISION without changing anything else the users who have the thing installed will get the corrected plist. This can matter if they deinstall the port later rather than upgrading it. It can also matter if the upgrade changes the plist again. >> It's needed for package cluster, otherwise it does not know to rebuild >> and will serve incomplete package forever. > > Is there ever a change then that doesn't require a bump in either > PORTREVISION or PORTVERSION? Yes. If the package isn't going to change, no PORTREVISION bump should be done. Someone else already provided examples, but they are numerous. > If not, maybe we should do away with PORTREVISION and use something like: > > ${PORTNAME}-${PORTVERSION}_${VCS_ID} I actually have in mind a different scheme that replaces both PORTREVISION and PORTEPOCH with a date string like 200903231 that would be appended to each PKGNAME. It would completely remove the ambiguity (and the kludgy mess that both of the current variables have created), and has the extra added bonus that you could set it differently depending on which options the user has set without fear of creating ambiguity. But I digress ... Doug -- This .signature sanitized for your protection