From owner-svn-src-all@freebsd.org Tue Sep 15 14:15:47 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D607A3D3A39; Tue, 15 Sep 2020 14:15:47 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BrQHk29JWz47R5; Tue, 15 Sep 2020 14:15:45 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 08FEFVeg019084 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 15 Sep 2020 17:15:34 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 08FEFVeg019084 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 08FEFUDI019082; Tue, 15 Sep 2020 17:15:30 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 15 Sep 2020 17:15:30 +0300 From: Konstantin Belousov To: Warner Losh Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, peter@holm.cc Subject: Re: svn commit: r364944 - head/sys/kern Message-ID: <20200915141530.GM94807@kib.kiev.ua> References: <202008290429.07T4TrbH007764@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202008290429.07T4TrbH007764@repo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4BrQHk29JWz47R5 X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com X-Spamd-Result: default: False [1.04 / 15.00]; ARC_NA(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; NEURAL_HAM_LONG(-0.40)[-0.397]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all:c]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_SPAM_MEDIUM(0.87)[0.868]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.57)[0.568]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; MIME_TRACE(0.00)[0:+]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Sep 2020 14:15:47 -0000 On Sat, Aug 29, 2020 at 04:29:53AM +0000, Warner Losh wrote: > Author: imp > Date: Sat Aug 29 04:29:53 2020 > New Revision: 364944 > URL: https://svnweb.freebsd.org/changeset/base/364944 > > Log: > devctl: move to using a uma zone > > Convert the memory management of devctl. Rewrite if to make better > use of memory. This eliminates several mallocs (5? worse case) needed > to send a message. It's now possible to always send a message, though > if things are really backed up the oldest message will be dropped to > free up space for the newest. > > Add a static bus_child_{location,pnpinfo}_sb to start migrating to > sbuf instead of buffer + length. Use it in the new code. Other code > will be converted later (bus_child_*_str is only used inside of > subr_bus.c, though implemented in ~100 places in the tree). > > Reviewed by: markj@ > Differential Revision: https://reviews.freebsd.org/D26140 > > Modified: > head/sys/kern/subr_bus.c > > + } else { > + /* dei can't be NULL -- we know we have at least one in the zone */ > + dei = uma_zalloc(devsoftc.zone, M_NOWAIT); > + MPASS(dei != NULL); This does not work. I believe you need to disable per-cpu cache for the zone, at least. But I am not sure it is enough. https://people.freebsd.org/~pho/stress/log/kostik1314.txt