From owner-freebsd-ports@FreeBSD.ORG Tue Jul 11 02:46:55 2006 Return-Path: X-Original-To: ports@freebsd.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 338D916A4DF for ; Tue, 11 Jul 2006 02:46:55 +0000 (UTC) (envelope-from edwin@mavetju.org) Received: from mail2out.barnet.com.au (mail2out.barnet.com.au [202.83.176.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id A717443D55 for ; Tue, 11 Jul 2006 02:46:54 +0000 (GMT) (envelope-from edwin@mavetju.org) Received: by mail2out.barnet.com.au (Postfix, from userid 27) id BA4987073FE; Tue, 11 Jul 2006 12:46:47 +1000 (EST) X-Viruscan-Id: <44B311170000B3EB70C206@BarNet> Received: from mail2-auth.barnet.com.au (mail2.barnet.com.au [202.83.176.13]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mail2.barnet.com.au (Postfix) with ESMTP id 428FB7073F1 for ; Tue, 11 Jul 2006 12:46:47 +1000 (EST) Received: from k7.mavetju (unknown [10.251.1.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mail2-auth.barnet.com.au (Postfix) with ESMTP id ADA867073EC for ; Tue, 11 Jul 2006 12:46:46 +1000 (EST) Received: by k7.mavetju (Postfix, from userid 1001) id 0DFB7E6; Tue, 11 Jul 2006 12:46:46 +1000 (EST) Date: Tue, 11 Jul 2006 12:46:46 +1000 From: Edwin Groothuis To: ports@freebsd.org Message-ID: <20060711024646.GC946@k7.mavetju> References: <20060710233013.GB946@k7.mavetju> <20060711003919.GA1977@picobyte.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060711003919.GA1977@picobyte.net> User-Agent: Mutt/1.4.2.1i Cc: Subject: Re: Port building cookie files changed? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jul 2006 02:46:55 -0000 On Tue, Jul 11, 2006 at 01:39:20AM +0100, Shaun Amott wrote: > On Tue, Jul 11, 2006 at 09:30:13AM +1000, Edwin Groothuis wrote: > > > > In an old ports framework, the cookie files were like this: > > .patch_done.ipv6calc-0.51._usr_local > > > > In the current framework, the cookie files are like this: > > .patch_done.ipv6calc._usr_local > > > > This gives false, or bad, or broken, cookies, because when I rebuild > > the same port with a different version number, it thinks it already > > has done the patching (and extracting, and building etc). > > > > So... who sneaked this in bsd.port.mk and why? > > > > According to the CVS log: > > * Use a consistent name for the cookies file when PKGNAMEPREFIX/SUFFIX > are set after bsd.port.pre.mk. > > The patch / an explanation is in ports/94219. So it went from PKGNAME to PORTNAME, which kind of killed the PORTVERSION, PORTREVISION and PORTEPOCH parts of it. These should be added again. The _COOKIES aren't used anywhere in the pre-section, nor are they user variables. Moving them to the post-section in the original form would have been a better solution. IMHO of course :-) Edwin -- Edwin Groothuis | Personal website: http://www.mavetju.org edwin@mavetju.org | Weblog: http://weblog.barnet.com.au/edwin/