From owner-freebsd-arch@FreeBSD.ORG  Tue Feb 12 06:15:55 2013
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 738AD333;
 Tue, 12 Feb 2013 06:15:55 +0000 (UTC)
 (envelope-from mckusick@mckusick.com)
Received: from chez.mckusick.com (chez.mckusick.com
 [IPv6:2001:5a8:4:7e72:4a5b:39ff:fe12:452])
 by mx1.freebsd.org (Postfix) with ESMTP id 4DE366B1;
 Tue, 12 Feb 2013 06:15:55 +0000 (UTC)
Received: from chez.mckusick.com (localhost [127.0.0.1])
 by chez.mckusick.com (8.14.3/8.14.3) with ESMTP id r1C6FpP8086860;
 Mon, 11 Feb 2013 22:15:52 -0800 (PST)
 (envelope-from mckusick@chez.mckusick.com)
Message-Id: <201302120615.r1C6FpP8086860@chez.mckusick.com>
To: mike@karels.net
Subject: Re: Proposal: Unify printing the function name in panic messages() 
In-reply-to: <201302120601.r1C617Q9006038@mail.karels.net> 
Date: Mon, 11 Feb 2013 22:15:51 -0800
From: Kirk McKusick <mckusick@mckusick.com>
X-Spam-Status: No, score=0.0 required=5.0 tests=MISSING_MID, UNPARSEABLE_RELAY
 autolearn=failed version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on chez.mckusick.com
Cc: Adrian Chadd <adrian@freebsd.org>,
 Christoph Mallon <christoph.mallon@gmx.de>, Andriy Gapon <avg@freebsd.org>,
 freebsd-arch@freebsd.org
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Feb 2013 06:15:55 -0000

> To: Kirk McKusick <mckusick@mckusick.com>
> cc: John Baldwin <jhb@freebsd.org>, Adrian Chadd <adrian@freebsd.org>,
>         Christoph Mallon <christoph.mallon@gmx.de>,
>         Andriy Gapon <avg@freebsd.org>, freebsd-arch@freebsd.org
> From: Mike Karels <mike@karels.net>
> Subject: Re: Proposal: Unify printing the function name in panic messages() 
> Date: Tue, 12 Feb 2013 00:01:07 -0600
> 
> I'm not arguing against consistency, nor even agaist the proposal itself
> (as modified for a lower-case panic macro).  However,  I don't think the
> lack of consistency is the real problem.  "panic: watchdog timeout" tells
> me what I need to know, whether or not it includes "watchdog_fire" or the
> line number.  The only problem that has been pointed out is lack of
> uniqueness.  That is a simpler problem to handle, and isn't handled by
> the current proposal as I understand it.
> 
> 		Mike

Though the default for the current proposal gives just the function name,
in its verbose mode it give file, function, and line number. And in its
lean and mean mode, just the error string. This replacing the hodge-podge
that we have now. My main point is that it is a significant improvement
over what we have now.

	Kirk