From owner-svn-src-head@FreeBSD.ORG  Fri Jun  4 14:40:03 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A0E121065677;
	Fri,  4 Jun 2010 14:40:03 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 7D07E8FC12;
	Fri,  4 Jun 2010 14:40:03 +0000 (UTC)
Received: from fledge.watson.org (fledge.watson.org [65.122.17.41])
	by cyrus.watson.org (Postfix) with ESMTPS id 2447146B9D;
	Fri,  4 Jun 2010 10:40:03 -0400 (EDT)
Date: Fri, 4 Jun 2010 15:40:02 +0100 (BST)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Edward Tomasz Napierala <trasz@FreeBSD.org>
In-Reply-To: <201006031341.o53DftKm094269@svn.freebsd.org>
Message-ID: <alpine.BSF.2.00.1006041539180.17149@fledge.watson.org>
References: <201006031341.o53DftKm094269@svn.freebsd.org>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r208779 - head/sys/kern
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Jun 2010 14:40:03 -0000

On Thu, 3 Jun 2010, Edward Tomasz Napierala wrote:

> Author: trasz
> Date: Thu Jun  3 13:41:55 2010
> New Revision: 208779
> URL: http://svn.freebsd.org/changeset/base/208779
>
> Log:
>  The acl_cnt field is unsigned; no point in checking if it's >= 0.

I'd originally left these checks in despite the Coverity warnings to make the 
code robust against developer changes that might include making acl_cnt 
signed.  I'd prefer to put a compile-time assertion in, needless to say, and 
recommend that, since they've been removed, we add one.

Robert

>
>  Found with:	Coverity Prevent
>  CID:		3683
>
> Modified:
>  head/sys/kern/subr_acl_nfs4.c
>
> Modified: head/sys/kern/subr_acl_nfs4.c
> ==============================================================================
> --- head/sys/kern/subr_acl_nfs4.c	Thu Jun  3 13:04:56 2010	(r208778)
> +++ head/sys/kern/subr_acl_nfs4.c	Thu Jun  3 13:41:55 2010	(r208779)
> @@ -342,7 +342,6 @@ acl_nfs4_sync_acl_from_mode(struct acl *
> 	const int WRITE = 02;
> 	const int EXEC = 01;
>
> -	KASSERT(aclp->acl_cnt >= 0, ("aclp->acl_cnt >= 0"));
> 	KASSERT(aclp->acl_cnt <= ACL_MAX_ENTRIES,
> 	    ("aclp->acl_cnt <= ACL_MAX_ENTRIES"));
>
>