From owner-cvs-src@FreeBSD.ORG Sat Feb 3 04:14:40 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D184516A402; Sat, 3 Feb 2007 04:14:40 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (gate.funkthat.com [69.17.45.168]) by mx1.freebsd.org (Postfix) with ESMTP id A030613C474; Sat, 3 Feb 2007 04:14:40 +0000 (UTC) (envelope-from jmg@hydrogen.funkthat.com) Received: from hydrogen.funkthat.com (v0haiaeoouc6ywo3@localhost.funkthat.com [127.0.0.1]) by hydrogen.funkthat.com (8.13.6/8.13.3) with ESMTP id l134EdIX084277; Fri, 2 Feb 2007 20:14:39 -0800 (PST) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.13.6/8.13.3/Submit) id l134Edq4084276; Fri, 2 Feb 2007 20:14:39 -0800 (PST) (envelope-from jmg) Date: Fri, 2 Feb 2007 20:14:39 -0800 From: John-Mark Gurney To: Konstantin Belousov Message-ID: <20070203041439.GB779@funkthat.com> References: <200702020902.l1292Js7068643@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200702020902.l1292Js7068643@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i X-Operating-System: FreeBSD 5.4-RELEASE-p6 i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_witness.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Feb 2007 04:14:40 -0000 Konstantin Belousov wrote this message on Fri, Feb 02, 2007 at 09:02 +0000: > kib 2007-02-02 09:02:19 UTC > > FreeBSD src repository > > Modified files: > sys/kern subr_witness.c > Log: > Record kqueue -> struct mount mtx -> vnode interlock lock order to > catch the places where reverse lock order is instantiated. Umm... does the above mean that kqueue can be obtained before mount, and vnode interlock's? If so, that is incorrect, and it needs to be that the kqueue lock is last... The lock order the kqueue is knlist lock -> kqueue lock... Where knlist lock is the lock that protects the object (or knlist belonging to the object)... Do we have a way to signify that you do not obtain another lock once you have obtained the kqueue lock? -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."