From owner-svn-src-all@FreeBSD.ORG  Tue Dec 22 10:26:52 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B8FDA1065670;
	Tue, 22 Dec 2009 10:26:52 +0000 (UTC) (envelope-from des@des.no)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
	by mx1.freebsd.org (Postfix) with ESMTP id 710218FC1A;
	Tue, 22 Dec 2009 10:26:52 +0000 (UTC)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id 7B9231FFC1E;
	Tue, 22 Dec 2009 10:26:51 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
	id 3232A84513; Tue, 22 Dec 2009 11:26:51 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: "M. Warner Losh" <imp@bsdimp.com>
References: <200912161541.53834.jhb@freebsd.org> <868wd0cyjd.fsf@ds4.des.no>
	<4B2C127A.8060509@FreeBSD.org>
	<20091221.204959.104237699577179806.imp@bsdimp.com>
Date: Tue, 22 Dec 2009 11:26:51 +0100
In-Reply-To: <20091221.204959.104237699577179806.imp@bsdimp.com> (M. Warner
	Losh's message of "Mon, 21 Dec 2009 20:49:59 -0700 (MST)")
Message-ID: <864onj8ftg.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.95 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, dougb@FreeBSD.org,
	jhb@FreeBSD.org, src-committers@FreeBSD.org
Subject: Re: svn commit: r200606 - in head/sys: compat/freebsd32 sys
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Dec 2009 10:26:52 -0000

"M. Warner Losh" <imp@bsdimp.com> writes:
> The trouble is that we need to do this globally, or certain
> definitions don't get defined.  It is easier to just #error out than
> hack config to do the right thing I think...

Suggestion: Introduce <sys/_compat.h> which includes "opt_compat.h" and
contains the appropriate logic, then s@"opt_compat.h"@<sys/_compat.h>@
throughout the kernel.  While you're there, add #include <sys/_compat.h>
inside #ifdef _KERNEL in headers that use the COMPAT_FREEBSDn macros
(e.g. fcntl.h) and see what breaks...

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no