From owner-freebsd-bugs@FreeBSD.ORG Thu May 20 07:00:44 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CE48B16A4CE for ; Thu, 20 May 2004 07:00:44 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id AE55743D46 for ; Thu, 20 May 2004 07:00:44 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i4KE0iO3096213 for ; Thu, 20 May 2004 07:00:44 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i4KE0ir8096212; Thu, 20 May 2004 07:00:44 -0700 (PDT) (envelope-from gnats) Date: Thu, 20 May 2004 07:00:44 -0700 (PDT) Message-Id: <200405201400.i4KE0ir8096212@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Jonathan Wakely" Subject: Re: misc/66941: Unacceptable stringstream performance X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Jonathan Wakely List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 May 2004 14:00:45 -0000 The following reply was made to PR misc/66941; it has been noted by GNATS. From: "Jonathan Wakely" To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org Cc: Subject: Re: misc/66941: Unacceptable stringstream performance Date: Thu, 20 May 2004 14:47:31 +0100 --0__=CgwBdOWltXmKD7rL5svL8tczv9OKuLWgjrqnxupQdt2vh8iahcnHaO6V Content-type: text/plain; charset=us-ascii Content-Disposition: inline This is the patch we've been using: (See attached file: sstream.patch) --0__=CgwBdOWltXmKD7rL5svL8tczv9OKuLWgjrqnxupQdt2vh8iahcnHaO6V Content-type: application/octet-stream; name="sstream.patch" Content-Disposition: attachment; filename="sstream.patch" Content-transfer-encoding: base64 LS0tIC91c3IvaW5jbHVkZS9nKysvc3N0cmVhbS5vcmlnCVRodSBGZWIgMTIgMDU6NTI6MjEgMjAw NAorKysgL3Vzci9pbmNsdWRlL2crKy9zc3RyZWFtCVRodSBNYXkgMjAgMTA6Mjg6MDMgMjAwNApA QCAtNDUsNyArNDUsNyBAQAogICAgIGV4cGxpY2l0CiAgICAgc3RyaW5nYnVmKGludCB3aGljaD1p b3M6OmlufGlvczo6b3V0KQogICAgICAgOiBzdHJlYW1idWYoKSwgbW9kZShzdGF0aWNfY2FzdDxp b3M6Om9wZW5fbW9kZT4od2hpY2gpKSwKLQlzdHJlYW0oTlVMTCksIHN0cmVhbV9sZW4oMCkKKwlz dHJlYW0oTlVMTCksIHN0cmVhbV9sZW4oMCksIHN0cmVhbV9jYXBhY2l0eSgwKQogICAgIHsKICAg ICAgIHN0cmluZ2J1Zl9pbml0KCk7CiAgICAgfQpAQCAtNTMsNyArNTMsNyBAQAogICAgIGV4cGxp Y2l0CiAgICAgc3RyaW5nYnVmKGNvbnN0IHN0cmluZyAmc3RyLCBpbnQgd2hpY2g9aW9zOjppbnxp b3M6Om91dCkKICAgICAgIDogc3RyZWFtYnVmKCksIG1vZGUoc3RhdGljX2Nhc3Q8aW9zOjpvcGVu X21vZGU+KHdoaWNoKSksCi0Jc3RyZWFtKE5VTEwpLCBzdHJlYW1fbGVuKDApCisJc3RyZWFtKE5V TEwpLCBzdHJlYW1fbGVuKDApLCBzdHJlYW1fY2FwYWNpdHkoMCkKICAgICB7CiAgICAgICBpZiAo bW9kZSAmIChpb3M6OmlufGlvczo6b3V0KSkKIAl7CkBAIC04Myw4ICs4Myw4IEBACiAgICAgc3Ry KGNvbnN0IHN0cmluZyYgc3RyKQogICAgIHsKICAgICAgIGRlbGV0ZVtdIHN0cmVhbTsKLSAgICAg IHN0cmVhbV9sZW4gPSBzdHIuc2l6ZSgpOwotICAgICAgc3RyZWFtID0gbmV3IGNoYXJfdHlwZVtz dHJlYW1fbGVuXTsKKyAgICAgIHN0cmVhbV9jYXBhY2l0eSA9IHN0cmVhbV9sZW4gPSBzdHIuc2l6 ZSgpOworICAgICAgc3RyZWFtID0gbmV3IGNoYXJfdHlwZVtzdHJlYW1fY2FwYWNpdHldOwogICAg ICAgc3RyLmNvcHkoc3RyZWFtLCBzdHJlYW1fbGVuKTsKICAgICAgIHN0cmluZ2J1Zl9pbml0KCk7 CiAgICAgfQpAQCAtMTA1LDEyICsxMDUsMTUgQEAKIAl7CiAJICBpZiAoYyAhPSBFT0YpCiAJICAg IHsKLQkgICAgICBzdHJlYW1zaXplIG9sZF9zdHJlYW1fbGVuID0gc3RyZWFtX2xlbjsKKwkgICAg ICBpZiAoc3RyZWFtX2xlbiA+PSBzdHJlYW1fY2FwYWNpdHkpCisJCXsKKwkJICBzdHJlYW1fY2Fw YWNpdHkgPSAyICogc3RyZWFtX2xlbiArIDEwMDsKKwkJICBjaGFyX3R5cGUqIG5ld19zdHJlYW0g PSBuZXcgY2hhcl90eXBlW3N0cmVhbV9jYXBhY2l0eV07CisJCSAgbWVtY3B5KG5ld19zdHJlYW0s IHN0cmVhbSwgc3RyZWFtX2xlbik7CisJCSAgZGVsZXRlW10gc3RyZWFtOworCQkgIHN0cmVhbSA9 IG5ld19zdHJlYW07CisJCX0KIAkgICAgICBzdHJlYW1fbGVuICs9IDE7Ci0JICAgICAgY2hhcl90 eXBlKiBuZXdfc3RyZWFtID0gbmV3IGNoYXJfdHlwZVtzdHJlYW1fbGVuXTsKLQkgICAgICBtZW1j cHkobmV3X3N0cmVhbSwgc3RyZWFtLCBvbGRfc3RyZWFtX2xlbik7Ci0JICAgICAgZGVsZXRlW10g c3RyZWFtOwotCSAgICAgIHN0cmVhbSA9IG5ld19zdHJlYW07CiAJICAgICAgc3RyaW5nYnVmX3N5 bmMoZ3B0cigpLWViYWNrKCksIHBwdHIoKS1wYmFzZSgpKTsKIAkgICAgICBzcHV0YyhjKTsKIAkg ICAgICByZXMgPSBjOwpAQCAtMjI1LDYgKzIyOCw3IEBACiAgICAgaW9zOjpvcGVuX21vZGUJbW9k ZTsKICAgICBjaGFyX3R5cGUqCQlzdHJlYW07CiAgICAgc3RyZWFtc2l6ZQkJc3RyZWFtX2xlbjsK KyAgICBzdHJlYW1zaXplCQlzdHJlYW1fY2FwYWNpdHk7CiAgIH07CiAMCiAgIGNsYXNzIGlzdHJp bmdzdHJlYW0gOiBwdWJsaWMgaXN0cmVhbSB7Cg== --0__=CgwBdOWltXmKD7rL5svL8tczv9OKuLWgjrqnxupQdt2vh8iahcnHaO6V--