Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 24 Mar 2012 10:29:47 -0500
From:      Jeremy Messenger <mezz.freebsd@gmail.com>
To:        Cy Schubert <Cy.Schubert@komquats.com>
Cc:        gnome@freebsd.org
Subject:   Re: gnome-terminal Bug 646317
Message-ID:  <CADLFttftadJg%2BhX%2BAa16iABSmmXRjt9DutYecNTAHnuVEx1t6g@mail.gmail.com>
In-Reply-To: <201203240420.q2O4KgYC049011@slippy.cwsent.com>
References:  <201203240420.q2O4KgYC049011@slippy.cwsent.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 23, 2012 at 11:20 PM, Cy Schubert <Cy.Schubert@komquats.com> wr=
ote:
> Gnome bugzilla bug 646317 (https://bugzilla.gnome.org/show_bug.cgi?id=3D6=
46317
> ) addresses a bug in gnome-terminal in which it returns an invalid exit
> status causing some environments (e.g. e17) to complain
> (http://trac.enlightenment.org/e/ticket/823). Would anyone mind if I
> committed the following patch, obtained from https://bugzilla.gnome.org/s=
how
> _bug.cgi?id=3D646317, =A0to gnome-terminal?

You can go ahead commit it. Thanks!

Cheers,
Mezz


> Index: Makefile
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /home/pcvs/ports/x11/gnome-terminal/Makefile,v
> retrieving revision 1.72
> diff -u -r1.72 Makefile
> --- Makefile =A0 =A023 Sep 2011 22:26:11 -0000 =A0 =A0 =A01.72
> +++ Makefile =A0 =A024 Mar 2012 04:12:38 -0000
> @@ -8,6 +8,7 @@
>
> =A0PORTNAME=3D =A0 =A0 =A0gnome-terminal
> =A0PORTVERSION=3D =A0 2.32.1
> +PORTREVISION=3D =A01
> =A0CATEGORIES=3D =A0 =A0x11 gnome
> =A0MASTER_SITES=3D =A0GNOME
> =A0DIST_SUBDIR=3D =A0 gnome2
> Index: files/patch-src-terminal.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: files/patch-src-terminal.c
> diff -N files/patch-src-terminal.c
> --- /dev/null =A0 1 Jan 1970 00:00:00 -0000
> +++ files/patch-src-terminal.c =A024 Mar 2012 04:12:38 -0000
> @@ -0,0 +1,11 @@
> +--- src/terminal.c.orig =A0 =A0 =A0 =A02010-11-10 10:47:14.000000000 -08=
00
> ++++ src/terminal.c =A0 =A0 2012-03-23 21:10:08.520503912 -0700
> +@@ -579,7 +579,7 @@
> + =A0 =A0 data =3D g_new (OwnData, 1);
> + =A0 =A0 data->factory_name =3D get_factory_name_for_display (display_na=
me);
> + =A0 =A0 data->options =3D options;
> +- =A0 =A0data->exit_code =3D -1;
> ++ =A0 =A0data->exit_code =3D EXIT_SUCCESS;
> + =A0 =A0 data->argv =3D argv_copy;
> + =A0 =A0 data->argc =3D argc_copy;
> +
>
>
>
> --
> Cheers,
> Cy Schubert <Cy.Schubert@komquats.com>
> FreeBSD UNIX: =A0<cy@FreeBSD.org> =A0 Web: =A0http://www.FreeBSD.org
>
> =A0 =A0 =A0 =A0The need of the many outweighs the greed of the few.
>
>
> _______________________________________________
> freebsd-gnome@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-gnome
> To unsubscribe, send any mail to "freebsd-gnome-unsubscribe@freebsd.org"



--=20
mezz.freebsd@gmail.com - mezz@FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLFttftadJg%2BhX%2BAa16iABSmmXRjt9DutYecNTAHnuVEx1t6g>