From owner-freebsd-gnome@FreeBSD.ORG Sat Mar 24 15:29:48 2012 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 577C5106566C for ; Sat, 24 Mar 2012 15:29:48 +0000 (UTC) (envelope-from mezz.freebsd@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 1E80B8FC17 for ; Sat, 24 Mar 2012 15:29:47 +0000 (UTC) Received: by iahk25 with SMTP id k25so8002386iah.13 for ; Sat, 24 Mar 2012 08:29:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=P0A8l1E5atwvvjL0HkChBxPJWmUk7lZ5FUith49OG9o=; b=jMwooXmsNpLQvaz05jxib7MlWdeHhaHvsiF7BtqNJgE/u7/Xd3GUWBgi5vudjWKyhR viP9XoURcnUdIlWCBzG86qMxmXqZRPtpwMzVSb1+gURqWV0saUp0ceA9e1NAuGTIl7oD 8yFOmjypWIHakdXK+pjtM0fnWSWnX6BSpZxW7GMRyEUGWIwNQuZIN+chPa/NfdL9MkOu mwCVKioFhuk3Xs3f0TzDLJ5umVLlhmlWiqrnVk+QxPJwz1fQDJSv6u3NCyCeoy3/zkIB 69uCE5XxujYwy+ZZUExT6a2oONSKAk0uMWnKsvTy3YO/QvUn1ms5CH8lDPvR7iB+mRCd OK/A== MIME-Version: 1.0 Received: by 10.50.192.228 with SMTP id hj4mr1665231igc.72.1332602987433; Sat, 24 Mar 2012 08:29:47 -0700 (PDT) Received: by 10.42.217.202 with HTTP; Sat, 24 Mar 2012 08:29:47 -0700 (PDT) In-Reply-To: <201203240420.q2O4KgYC049011@slippy.cwsent.com> References: <201203240420.q2O4KgYC049011@slippy.cwsent.com> Date: Sat, 24 Mar 2012 10:29:47 -0500 Message-ID: From: Jeremy Messenger To: Cy Schubert Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: gnome@freebsd.org Subject: Re: gnome-terminal Bug 646317 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Mar 2012 15:29:48 -0000 On Fri, Mar 23, 2012 at 11:20 PM, Cy Schubert wr= ote: > Gnome bugzilla bug 646317 (https://bugzilla.gnome.org/show_bug.cgi?id=3D6= 46317 > ) addresses a bug in gnome-terminal in which it returns an invalid exit > status causing some environments (e.g. e17) to complain > (http://trac.enlightenment.org/e/ticket/823). Would anyone mind if I > committed the following patch, obtained from https://bugzilla.gnome.org/s= how > _bug.cgi?id=3D646317, =A0to gnome-terminal? You can go ahead commit it. Thanks! Cheers, Mezz > Index: Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/pcvs/ports/x11/gnome-terminal/Makefile,v > retrieving revision 1.72 > diff -u -r1.72 Makefile > --- Makefile =A0 =A023 Sep 2011 22:26:11 -0000 =A0 =A0 =A01.72 > +++ Makefile =A0 =A024 Mar 2012 04:12:38 -0000 > @@ -8,6 +8,7 @@ > > =A0PORTNAME=3D =A0 =A0 =A0gnome-terminal > =A0PORTVERSION=3D =A0 2.32.1 > +PORTREVISION=3D =A01 > =A0CATEGORIES=3D =A0 =A0x11 gnome > =A0MASTER_SITES=3D =A0GNOME > =A0DIST_SUBDIR=3D =A0 gnome2 > Index: files/patch-src-terminal.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: files/patch-src-terminal.c > diff -N files/patch-src-terminal.c > --- /dev/null =A0 1 Jan 1970 00:00:00 -0000 > +++ files/patch-src-terminal.c =A024 Mar 2012 04:12:38 -0000 > @@ -0,0 +1,11 @@ > +--- src/terminal.c.orig =A0 =A0 =A0 =A02010-11-10 10:47:14.000000000 -08= 00 > ++++ src/terminal.c =A0 =A0 2012-03-23 21:10:08.520503912 -0700 > +@@ -579,7 +579,7 @@ > + =A0 =A0 data =3D g_new (OwnData, 1); > + =A0 =A0 data->factory_name =3D get_factory_name_for_display (display_na= me); > + =A0 =A0 data->options =3D options; > +- =A0 =A0data->exit_code =3D -1; > ++ =A0 =A0data->exit_code =3D EXIT_SUCCESS; > + =A0 =A0 data->argv =3D argv_copy; > + =A0 =A0 data->argc =3D argc_copy; > + > > > > -- > Cheers, > Cy Schubert > FreeBSD UNIX: =A0 =A0 Web: =A0http://www.FreeBSD.org > > =A0 =A0 =A0 =A0The need of the many outweighs the greed of the few. > > > _______________________________________________ > freebsd-gnome@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-gnome > To unsubscribe, send any mail to "freebsd-gnome-unsubscribe@freebsd.org" --=20 mezz.freebsd@gmail.com - mezz@FreeBSD.org FreeBSD GNOME Team http://www.FreeBSD.org/gnome/ - gnome@FreeBSD.org