From owner-cvs-src@FreeBSD.ORG Mon Feb 14 20:07:06 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4E72116A4CE; Mon, 14 Feb 2005 20:07:06 +0000 (GMT) Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id 93AD143D54; Mon, 14 Feb 2005 20:07:05 +0000 (GMT) (envelope-from marcus@marcuscom.com) Received: from [10.2.1.2] (vpn-client-2.marcuscom.com [10.2.1.2]) j1EK7SKS093760; Mon, 14 Feb 2005 15:07:28 -0500 (EST) (envelope-from marcus@marcuscom.com) Message-ID: <421104E5.6040705@marcuscom.com> Date: Mon, 14 Feb 2005 15:07:01 -0500 From: Joe Marcus Clarke Organization: MarcusCom, Inc. User-Agent: Mozilla Thunderbird 1.0 (Macintosh/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Eischen References: In-Reply-To: X-Enigmail-Version: 0.89.5.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on creme-brulee.marcuscom.com cc: John-Mark Gurney cc: src-committers@freebsd.org cc: Maxime Henrion cc: cvs-src@freebsd.org cc: Alfred Perlstein cc: Scott Long cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_attr_init.cthr_init.c thr_private.h thr_stack.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Feb 2005 20:07:06 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Daniel Eischen wrote: | On Mon, 14 Feb 2005, Scott Long wrote: | | |>Daniel Eischen wrote: |> |> |>>>* Joe Marcus Clarke [050213 20:30] wrote: |>>> |>>> |>>>>This works for all threads but the initial thread. Gstreamer uses this |>>>>thread for most of its operations. That stack size was set to be 1 MB |>>>>when gstreamer really wanted 2. For all other thread problems, yes, I |>>>>used pthread_attr_setstacksize() as the solution. |>>> |>>>Can't you wrap main and bounce into it with a thread that has been |>>>created using pthread_attr_setstacksize()? |>> |>> |>>Exactly! |>> |> |>Again, I think that you have to look at the problem of supporting apps |>that are written in a linux-centric way by authors who aren't interested |>in merging back changes that complicate the code. | | | I (think) we're talking about existing patches to ports. | | | The simple way get a bigger main thread stack is to create | another thread with larger stack to run whatever main runs. | There wasn't a need to have ports with reduced functionality | just because the main thread's stack wasn't large enough. | I couldn't find an easy way to do that with cothreads in gstreamer. However, this is exactly what I did with other ports. | | | We have a larger default stacksize for the main thread, so | this should solve any related problems that ports had. | Yep, and I'm happy to have it (don't get me wrong). However, I was hoping to have a way to know when it was safe to remove at least the gstreamer hack, and that's why I asked for the __FreeBSD_version bump. Joe | - -- PGP Key : http://www.marcuscom.com/pgp.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.0 (Darwin) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCEQTlb2iPiv4Uz4cRApIaAJ9awg4zyv2lKvh2394IHffKhtLbkwCfYryx KQyeYaIL9qyEMGxwgMWMxnI= =Wq5h -----END PGP SIGNATURE-----