From owner-freebsd-rc@FreeBSD.ORG Sat Oct 27 17:55:26 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7E846847 for ; Sat, 27 Oct 2012 17:55:26 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id CD7F58FC0A for ; Sat, 27 Oct 2012 17:55:25 +0000 (UTC) Received: from alph.allbsd.org (p1137-ipbf1505funabasi.chiba.ocn.ne.jp [118.7.212.137]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id q9RHtADV080633 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 28 Oct 2012 02:55:20 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.allbsd.org (8.14.5/8.14.5) with ESMTP id q9RHt9Jd050313; Sun, 28 Oct 2012 02:55:09 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sun, 28 Oct 2012 02:55:06 +0900 (JST) Message-Id: <20121028.025506.866731529487557055.hrs@allbsd.org> To: utisoft@gmail.com Subject: Re: Spaces in ${name}_chroot From: Hiroki Sato In-Reply-To: References: <20121028.021752.529031225588915529.hrs@allbsd.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Sun_Oct_28_02_55_06_2012_643)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Sun, 28 Oct 2012 02:55:20 +0900 (JST) X-Spam-Status: No, score=-98.1 required=13.0 tests=CONTENT_TYPE_PRESENT, ONLY1HOPDIRECT,SAMEHELOBY2HOP,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2012 17:55:26 -0000 ----Security_Multipart(Sun_Oct_28_02_55_06_2012_643)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Chris Rees wrote in : ut> On 27 October 2012 18:17, Hiroki Sato wrote: ut> > Chris Rees wrote ut> > in : ut> > ut> > ut> Hi all, ut> > ut> ut> > ut> A guy in IRC pointed out to me that rc.subr will not work correctly if ut> > ut> a chroot has spaces in it. ut> > ut> ut> > ut> Although this is unlikely, would it hurt to include it? Lacking a src ut> > ut> bit someone may need to put their name to it, but I'm happy to commit ut> > ut> & handle MFCs. ut> > ut> ut> > ut> Chris ut> > ut> ut> > ut> [1] http://www.bayofrum.net/~crees/patches/rc-subr-support-chroot-spaces.diff ut> > ut> > I think this patch is correct. Please go ahead. ut> ut> Should I give it 1 month MFC, or leave it in head? I think this can be merged safely. Let's see if something goes wrong with this patch in head for a while. -- Hiroki ----Security_Multipart(Sun_Oct_28_02_55_06_2012_643)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAlCMH/sACgkQTyzT2CeTzy0X3wCdFGWWqib99sc7eA+xqvrz9Xm5 QqUAoKaOuoTPG9nFNycYIW3zo4zDp2rr =+aEG -----END PGP SIGNATURE----- ----Security_Multipart(Sun_Oct_28_02_55_06_2012_643)----