From owner-freebsd-current@freebsd.org Fri Jan 1 20:40:16 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 894F04D30E9 for ; Fri, 1 Jan 2021 20:40:16 +0000 (UTC) (envelope-from me+freebsd@igalic.co) Received: from mail-40136.protonmail.ch (mail-40136.protonmail.ch [185.70.40.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "protonmail.com", Issuer "SwissSign Server Gold CA 2014 - G22" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D6xjV1kpdz3pBf for ; Fri, 1 Jan 2021 20:40:14 +0000 (UTC) (envelope-from me+freebsd@igalic.co) Date: Fri, 01 Jan 2021 20:40:07 +0000 To: Allan Jude From: =?utf-8?Q?Mina_Gali=C4=87?= Cc: FreeBSD Current Reply-To: =?utf-8?Q?Mina_Gali=C4=87?= Subject: Re: Enabling AESNI by default Message-ID: In-Reply-To: <5d56280e-a8dd-b28d-7039-f8fe0bc0cd6f@freebsd.org> References: <5d56280e-a8dd-b28d-7039-f8fe0bc0cd6f@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch X-Rspamd-Queue-Id: 4D6xjV1kpdz3pBf X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.79 / 15.00]; HAS_REPLYTO(0.00)[me+freebsd@igalic.co]; R_SPF_ALLOW(-0.20)[+ip4:185.70.40.0/24]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[igalic.co:+]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[185.70.40.136:from]; R_MIXED_CHARSET(0.71)[subject]; ASN(0.00)[asn:62371, ipnet:185.70.40.0/24, country:CH]; TAGGED_FROM(0.00)[freebsd]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[igalic.co:s=protonmail2]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[me]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[igalic.co]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; SPAMHAUS_ZRD(0.00)[185.70.40.136:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[185.70.40.136:from]; MAILMAN_DEST(0.00)[freebsd-current] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jan 2021 20:40:16 -0000 On Thursday, December 31st, 2020 at 20:51, Allan Jude wrote: > We've had the AESNI module for quite a few years now, and it has not caus= ed any problems. > > I am wondering if there are any objections to including it in GENERIC, so= that users get the benefit without having to have the "tribal knowledge" t= hat 'to accelerate kernel crypto (GELI, ZFS, IPSEC, etc), you need to load = aesni.ko' This tribal knowledge is encoded in bsdinstall when you setup encryption on= zfs: https://cgit.freebsd.org/src/tree/usr.sbin/bsdinstall/scripts/zfsboot#n1207 Mina