From owner-freebsd-smp Tue Oct 3 12:19: 6 2000 Delivered-To: freebsd-smp@freebsd.org Received: from mail.rdc1.va.home.com (ha1.rdc1.va.home.com [24.2.32.66]) by hub.freebsd.org (Postfix) with ESMTP id 5841A37B66C for ; Tue, 3 Oct 2000 12:19:04 -0700 (PDT) Received: from laptop.baldwin.cx ([24.6.244.187]) by mail.rdc1.va.home.com (InterMail vM.4.01.03.00 201-229-121) with ESMTP id <20001003191903.TLXF26082.mail.rdc1.va.home.com@laptop.baldwin.cx>; Tue, 3 Oct 2000 12:19:03 -0700 Content-Length: 1182 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200010031908.e93J8OS00830@troutmask.apl.washington.edu> Date: Tue, 03 Oct 2000 12:19:07 -0700 (PDT) From: John Baldwin To: Steve Kargl Subject: Re: witness code status? Cc: freebsd-smp@FreeBSD.org, Jake Burkholder Sender: owner-freebsd-smp@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On 03-Oct-00 Steve Kargl wrote: > John Baldwin wrote: >> >> On 03-Oct-00 Jake Burkholder wrote: >> > Attached is a patch that should fix this. >> > Please let me know and I'll commit it. (Works here.) >> >> Ugh. How and why does this work exactly, and should we be >> #include'ing opt_user_ldt.h in an include file instead, or >> should we move USER_LDT to opt_global.h perhaps? >> > > Well, it appears to work because > troutmask:sgk[247] find /sys/ -name \*.h | xargs grep USER_LDT > /sys/compile/TROUTMASK/opt_user_ldt.h:#define USER_LDT 1 > /sys/i386/include/globaldata.h:#ifdef USER_LDT > /sys/i386/include/globals.h:#ifdef USER_LDT > /sys/i386/include/globals.h:#ifdef USER_LDT Argh. Ok. In some other header files we create dummy variables so that the structs remain the same. > And kern_idle.c includes > >#include >#include > > which suggests that yes USER_LDT should move to opt_global.h. I'll work up a patch to do this in a sec. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message