From owner-cvs-src@FreeBSD.ORG  Wed Jul 28 21:57:31 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0B53216A4CE; Wed, 28 Jul 2004 21:57:31 +0000 (GMT)
Received: from pasmtp.tele.dk (pasmtp.tele.dk [193.162.159.95])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5E3E743D66; Wed, 28 Jul 2004 21:57:30 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (0x50a07c53.naenxx7.adsl-dhcp.tele.dk
	[80.160.124.83])
	by pasmtp.tele.dk (Postfix) with ESMTP id EF3591EC48A;
	Wed, 28 Jul 2004 23:57:27 +0200 (CEST)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i6SLGL2K047641;
	Wed, 28 Jul 2004 23:16:22 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: Marius Strobl <marius@alchemy.franken.de>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Wed, 28 Jul 2004 23:37:51 +0200."
             <20040728233751.A31182@newtrinity.zeist.de> 
Date: Wed, 28 Jul 2004 23:16:21 +0200
Message-ID: <47640.1091049381@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: Brian Feldman <green@FreeBSD.org>
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/watchdogd watchdogd.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Jul 2004 21:57:31 -0000

In message <20040728233751.A31182@newtrinity.zeist.de>, Marius Strobl writes:
>On Fri, Jul 23, 2004 at 03:24:58PM +0000, Brian Feldman wrote:
>> green       2004-07-23 15:24:58 UTC
>> 
>>   FreeBSD src repository
>> 
>>   Modified files:
>>     usr.sbin/watchdogd   watchdogd.c 
>>   Log:
>>   Now that mlockall(2) is unbroken, use it to keep watchdogd(8) permanently
>>   out of swap.
>>   
>
>This broke watchdogd(8) on at least alpha and sparc64:
>omega# watchdogd
>watchdogd: mlockall: Resource temporarily unavailable
>
>Like I told you before, every call of mlockall(MCL_CURRENT) returns -1
>and sets errno to EAGAIN on these platforms.

Worse, if it had worked it would have prevented watchdogd from
detecting swap disk related issues.

The only kind of special treatment you should give a watchdog daemons
is negative benefits so that it will be more sensitive to trouble.

Please back this out.


-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.