Date: Sun, 23 Apr 2023 19:09:31 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Graham Perrin <grahamperrin@freebsd.org> Cc: gecko@FreeBSD.org Subject: Re: Fix the restart button Message-ID: <0CE2B73C-40DE-4A03-9CE7-2D945F095EEC@FreeBSD.org> In-Reply-To: <9c3c73c9-797f-e526-9146-1d0464cbf1ce@freebsd.org> References: <20220616072952.o7jeeiswo6x5ftok@aniel.nours.eu> <9c3c73c9-797f-e526-9146-1d0464cbf1ce@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Le 23 avril 2023 18:40:53 GMT+02:00, Graham Perrin <grahamperrin@freebsd=2E= org> a =C3=A9crit=C2=A0: >On 16/06/2022 08:29, Baptiste Daroussin wrote: > >> Hello, >>=20 >> I have stolen this patch from OpenBSD, which was done to please pledge,= but in >> the end fixes the restart button=2E >>=20 >> https://bapt=2Enours=2Eeu/patch-xpcom_build_BinaryPath=2Eh >>=20 >> If my investigation is right, firefox when one click on the restart but= ton (in >> case of upgrade) will call for the sysctl KERN_PROC_PATHNAME, which wil= l return >> en empty value, because the binary has been unlinked and replace by the= new one=2E >> (the behaviour is different on linux here) but forcing the path at buil= dtime >> make it work reliably and at least here, it makes the restart button wo= rking >> reliably >>=20 >> note that it needs a post-patch target to replace %%PREFIX%% in >> xpcom/build/BinaryPath=2Eh file=2E >>=20 >> Best regards, >> Bapt > >Hi > >With Firefox 112=2E0=2E1_1,2, I can not find a restart button in toolbar = customisation preferences=2E > >Is the patch intended to make visible and/or functional a button that alr= eady exists in Firefox? Or intended to add a button, a feature request? > When firefox is running when being upgraded, then if you open a new tab, = a restart button appears instead of the rendered page=2E If you click it no= w it just kills firefox and never restart it=2E The same similar fix is app= lied on openbsd=2E=2E=2E The patch probably does not apply any more and giv= en the maintainers did not show any interest I will not update it=2E Bapt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0CE2B73C-40DE-4A03-9CE7-2D945F095EEC>