From owner-freebsd-alpha@FreeBSD.ORG Thu Aug 11 20:27:12 2005 Return-Path: X-Original-To: alpha@freebsd.org Delivered-To: freebsd-alpha@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0585916A41F; Thu, 11 Aug 2005 20:27:12 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id 76F1543D48; Thu, 11 Aug 2005 20:27:11 +0000 (GMT) (envelope-from marcel@xcllnt.net) Received: from [192.168.4.250] (dhcp50.pn.xcllnt.net [192.168.4.250]) by ns1.xcllnt.net (8.13.4/8.13.4) with ESMTP id j7BKRBqQ005054; Thu, 11 Aug 2005 13:27:11 -0700 (PDT) (envelope-from marcel@xcllnt.net) In-Reply-To: <200508101656.23255.jhb@FreeBSD.org> References: <200508041255.05839.jhb@FreeBSD.org> <20050804212718.GD852@zaphod.nitro.dk> <200508101656.23255.jhb@FreeBSD.org> Mime-Version: 1.0 (Apple Message framework v733) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Marcel Moolenaar Date: Thu, 11 Aug 2005 13:27:09 -0700 To: John Baldwin X-Mailer: Apple Mail (2.733) Cc: alpha@freebsd.org, current@freebsd.org Subject: Re: Locking fixes for dc(4): please test! X-BeenThere: freebsd-alpha@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the Alpha List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2005 20:27:12 -0000 On Aug 10, 2005, at 1:56 PM, John Baldwin wrote: > On 2005.08.04 12:55:05 -0400, John Baldwin wrote: > >> I have some fixes for the locking in the dc(4) driver, please test >> them >> if you have some dc(4) hardware, thanks! >> >> http://www.FreeBSD.org/~jhb/patches/dc_locking.patch >> > > I've updated the patch to use callout_init_mtx() and would > appreciate it if > the folks who tested it earlier could retest it. Also, can someone > with an > Alpha please test this as I messed around with the SRM_MEDIA code > some in > order to make the locking in dc_init_locked() sane and it needs > testing on an > Alpha. It doesn't build on alpha: ds10% cd /sys/alpha/compile/DS10 ds10% make cc -c -O -pipe -mcpu=ev6 -mieee -Wall -Wredundant-decls -Wnested- externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith - Winline -Wcast-qual -fformat-extensions -std=c99 -g -nostdinc -I- - I. -I../../.. -I../../../contrib/dev/acpica -I../../../contrib/altq - I../../../contrib/ipfilter -I../../../contrib/pf -I../../../contrib/ dev/ath -I../../../contrib/dev/ath/freebsd -I../../../contrib/ngatm - I../../../dev/twa -D_KERNEL -include opt_global.h -fno-common - finline-limit=15000 --param inline-unit-growth=100 --param large- function-growth=1000 -mno-fp-regs -ffixed-8 -Wa,-mev6 -ffreestanding -Werror ../../../pci/if_dc.c ../../../pci/if_dc.c: In function `dc_init': ../../../pci/if_dc.c:3407: error: `ifp' undeclared (first use in this function) ../../../pci/if_dc.c:3407: error: (Each undeclared identifier is reported only once ../../../pci/if_dc.c:3407: error: for each function it appears in.) ../../../pci/if_dc.c:3407: error: `mii' undeclared (first use in this function) *** Error code 1 ...The SRM_MEDIA macro is probably only defined on alpha... -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net