Date: Sun, 17 Aug 2014 21:38:38 +0200 From: Kurt Jaeger <pi@FreeBSD.org> To: Antoine Brodin <antoine@FreeBSD.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, Kurt Jaeger <pi@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r365227 - head/Mk/Uses Message-ID: <20140817193838.GO42528@f10.opsec.eu> In-Reply-To: <CAALwa8mFdvSQRPgPVntA4x%2BQMH2ceVOWQXB1KZiGHQEGA4M9gw@mail.gmail.com> References: <201408171932.s7HJWIkV088586@svn.freebsd.org> <CAALwa8mFdvSQRPgPVntA4x%2BQMH2ceVOWQXB1KZiGHQEGA4M9gw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi!
> > Log:
> > Mk/Uses/perl5.mk: Fix logic for removal of empty .bs files
[...]
> > # Starting with perl 5.20, the empty bootstrap files are not installed any
> > # more. As we don't need them anyway, remove it altogether.
> > -.if ${PERL_LEVEL} < 502000
> > +.if ${PERL_LEVEL} >= 502000
> > fix-perl-bs:
> > -@${FIND} ${STAGEDIR} -name '*.bs' -size 0 -delete
> > .endif
>
>
> This is totally wrong, please revert.
I had the case with devel/p5-File-Map that it still installs a
.bs in the STAGEDIR. So I searched on how to fix it and found this
please in Mk/Uses/perl5.mk and thought:
Isn't the logic the wrong way around ?
Please explain the logic behind the fix-perl-bs for ${PERL_LEVEL} >= 502000 ?
--
pi@FreeBSD.org +49 171 3101372 6 years to go !
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140817193838.GO42528>