From owner-freebsd-toolchain@freebsd.org Mon Feb 3 05:41:39 2020 Return-Path: Delivered-To: freebsd-toolchain@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 30D09243E63 for ; Mon, 3 Feb 2020 05:41:39 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 489xXL3szHz46yL for ; Mon, 3 Feb 2020 05:41:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x734.google.com with SMTP id v195so13021670qkb.11 for ; Sun, 02 Feb 2020 21:41:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nnouIjDhaV5CJtqW9Gud+gPKczLhU6E+hs1jlRRP7Es=; b=Q38p/8XGbARpmOBKWOLNeJzMBzj2th7RQM2bM3xKezWjxJ3qwb9e0L7OtrIpBAEmhJ EZoS8FYtgYpuQYj8uOVPOPJ7AxNatoLkdm8KErIvQi0QQQZGRoL8NNsWLhXsLRzAT25a vLAtTWwW77vOqDEw828jVEA6C+oe16PkKCAiqJdJymfjMcF9czD2v3Ik1umYjvrEFmFt qiTzT1yuMf7p3JXlWTS947jI58cZqIUqpAOSQ764Mu4ACOUfadXvNhlMVeetFZ2DtVgT p1h1PLInQ0FGauM7WYEbPvnzokE4oD9ioPkyMYq/3n3PxWSYk/+NOImb2GGoOdweSl1C Wpyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nnouIjDhaV5CJtqW9Gud+gPKczLhU6E+hs1jlRRP7Es=; b=CyNRGMrwbwrvBn3niNakDtpAYQV2iaikB0AEczxs1wkdlgYquG9/yxEiv2BgDBxEDR Eg8X3QMpMQQYZ7Of0bLmeZAg1TJIvR1j8KvIW57WBkTrNBZ2Trq1A8OMhpZz+dh5cIS0 zH3lJ/2WCIfWoFx8aRLPa4VoUHLcQKMCd63PTm64Lvib97UFJz1jsOTH8Nqv/sUwOeqJ HKNP+vbwtdo/o83aG7403UNrDHl/eu+Y3F/xtbBqgkKnXeZgSNqJlpts/eUZi5ChdFfY WeEcmOOi32GJn4tFOxJP8adz8UCB0ZAUzuJ9sbkVyVJGRHFWPHu+Lihmmator0FYnNgt vSrA== X-Gm-Message-State: APjAAAU0QlXHBm4x9SxjAcj7VfU71RJ3O/UBD2eTouW9xILOiiscSaUU 2zktdxKmaIVURD7MpNh8KyxWwfnWa69vpdQj5B0NzA== X-Google-Smtp-Source: APXvYqzV7CSVLD9EIZHfFuSefJQQ5CqM6tQMEYyWGK3CznnH2n8JAJ/AIvc3R65sny1wfDq70/GvQPFc9WxNfxQbHaQ= X-Received: by 2002:a05:620a:2104:: with SMTP id l4mr20631332qkl.240.1580708497417; Sun, 02 Feb 2020 21:41:37 -0800 (PST) MIME-Version: 1.0 References: <1EDB31B4-7372-4D8C-AF81-685E53BE4810@yahoo.com> <13FEBAFC-8D69-4BE4-9558-97617639A0B4@yahoo.com> In-Reply-To: From: Warner Losh Date: Mon, 3 Feb 2020 06:41:25 +0100 Message-ID: Subject: Re: head -r357401 broke my powerpc/powerpc64 builds: I build with sc present [the added "static" caused the failures] To: Mark Millard Cc: FreeBSD Toolchain , FreeBSD PowerPC ML X-Rspamd-Queue-Id: 489xXL3szHz46yL X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=Q38p/8XG; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::734) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-4.61 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-toolchain@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[4.3.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; FREEMAIL_TO(0.00)[yahoo.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.61)[ip: (-9.23), ipnet: 2607:f8b0::/32(-2.00), asn: 15169(-1.76), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Feb 2020 05:41:39 -0000 On Mon, Feb 3, 2020 at 3:33 AM Mark Millard wrote: > [Turns out to be the added "static".] > > On 2020-Feb-2, at 15:10, Mark Millard wrote: > > > [I forgot to send some context.] > > > > On 2020-Feb-2, at 14:51, Mark Millard wrote: > > > >> --- kernel.full --- > >> ld: error: undefined symbol: dflt_font_8 > >>>>> referenced by ofw_syscons.c > >>>>> ofw_syscons.o:(.toc+0x10) > >> ld: error: undefined symbol: dflt_font_14 > >>>>> referenced by ofw_syscons.c > >>>>> ofw_syscons.o:(.toc+0x18) > >> ld: error: undefined symbol: dflt_font_16 > >>>>> referenced by ofw_syscons.c > >>>>> ofw_syscons.o:(.toc+0x20) > >> > >> This is from loss of: > >> > >> > >> > >> font.h optional sc > \ > >> compile-with "uudecode < > /usr/share/syscons/fonts/${SC_DFLT_FONT}-8x16.fnt && file2c 'u_char > dflt_font_16[16*256] = {' '};' < ${SC_DFLT_FONT}-8x16 > font.h && uudecode > < /usr/share/syscons/fonts/${SC_DFLT_FONT}-8x14.fnt && file2c 'u_char > dflt_font_14[14*256] = {' '};' < ${SC_DFLT_FONT}-8x14 >> font.h && uudecode > < /usr/share/syscons/fonts/${SC_DFLT_FONT}-8x8.fnt && file2c 'u_char > dflt_font_8[8*256] = {' '};' < ${SC_DFLT_FONT}-8x8 >> font.h" \ > >> no-obj no-implicit-rule before-depend > \ > >> clean "font.h ${SC_DFLT_FONT}-8x14 ${SC_DFLT_FONT}-8x16 > ${SC_DFLT_FONT}-8x8" > >> > >> > >> in /head/sys/conf/files.powerpc . > >> > >> > >> FYI for why I have sc present: > >> > >> Historically, I've had two PowerMac contexts, one of which > >> worked with sc but not vt and another of which worked with > >> vt but not sc. > >> > >> I build with both sc and vt present and change which is > >> used as I move the media between machines. > > > > FYI: my powerpc* kernel config files have (using a powerpc64 > > example): > > > > include "GENERIC64" > > > > . . . > > > > nooptions PS3 # Sony Playstation 3 > HACK!!! to allow sc > > > > . . . > > > > # HACK!!! to allow sc for 2560x1440 display on Radeon X1950 that vt > historically mishandled during booting > > device sc > > #device kbdmux # HACK: already listed by vt > > options SC_OFWFB # OFW frame buffer > > options SC_DFLT_FONT # compile font in > > makeoptions SC_DFLT_FONT=cp437 > > > > > > I'm exploring rebuilding from scratch, but it > > may be that this change could use some form > > of UPDATING note about how to deal with the > > changes. > > The following enabled my powerpc* builds: I dropped > "static " from each declaration that is generated. > > (In this form some whitespace might not be > preserved below.) > > # svnlite diff /usr/src/sys/conf/files > Index: /usr/src/sys/conf/files > =================================================================== > --- /usr/src/sys/conf/files (revision 357419) > +++ /usr/src/sys/conf/files (working copy) > @@ -35,7 +35,7 @@ > no-obj no-implicit-rule before-depend > \ > clean "feeder_rate_gen.h" > font.h optional sc_dflt_font \ > - compile-with "uudecode < > ${SRCTOP}/share/syscons/fonts/${SC_DFLT_FONT}-8x16.fnt && file2c 'static > u_char dflt_font_16[16*256] = {' '};' < ${SC_DFLT_FONT}-8x16 > font.h && > uudecode < ${SRCTOP}/share/syscons/fonts/${SC_DFLT_FONT}-8x14.fnt && file2c > 'static u_char dflt_font_14[14*256] = {' '};' < ${SC_DFLT_FONT}-8x14 >> > font.h && uudecode < ${SRCTOP}/share/syscons/fonts/${SC_DFLT_FONT}-8x8.fnt > && file2c 'static u_char dflt_font_8[8*256] = {' '};' < ${SC_DFLT_FONT}-8x8 > >> font.h" > \ > + compile-with "uudecode < > ${SRCTOP}/share/syscons/fonts/${SC_DFLT_FONT}-8x16.fnt && file2c 'u_char > dflt_font_16[16*256] = {' '};' < ${SC_DFLT_FONT}-8x16 > font.h && uudecode > < ${SRCTOP}/share/syscons/fonts/${SC_DFLT_FONT}-8x14.fnt && file2c 'u_char > dflt_font_14[14*256] = {' '};' < ${SC_DFLT_FONT}-8x14 >> font.h && uudecode > < ${SRCTOP}/share/syscons/fonts/${SC_DFLT_FONT}-8x8.fnt && file2c 'u_char > dflt_font_8[8*256] = {' '};' < ${SC_DFLT_FONT}-8x8 >> font.h" > \ > no-obj no-implicit-rule before-depend \ > clean "font.h ${SC_DFLT_FONT}-8x14 ${SC_DFLT_FONT}-8x16 > ${SC_DFLT_FONT}-8x8" > snd_fxdiv_gen.h optional sound > \ > > > If the "static"s are strongly wanted, then the powerpc* > families need to be reworked to allow for such. > Yea, ofw_syscons.c reaches over into these arrays. I've removed the static for now. syscons is on the way out, so I don't want to waste too much time on it. warner > > === > Mark Millard > marklmi at yahoo.com > ( dsl-only.net went > away in early 2018-Mar) > >