From owner-freebsd-net@FreeBSD.ORG  Mon Apr 13 14:30:03 2009
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 670E1106567C
	for <freebsd-net@hub.freebsd.org>; Mon, 13 Apr 2009 14:30:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 54A2F8FC0C
	for <freebsd-net@hub.freebsd.org>; Mon, 13 Apr 2009 14:30:03 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n3DEU3Ib060109
	for <freebsd-net@freefall.freebsd.org>; Mon, 13 Apr 2009 14:30:03 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n3DEU3gw060098;
	Mon, 13 Apr 2009 14:30:03 GMT (envelope-from gnats)
Date: Mon, 13 Apr 2009 14:30:03 GMT
Message-Id: <200904131430.n3DEU3gw060098@freefall.freebsd.org>
To: freebsd-net@FreeBSD.org
From: Brett Glass <brett@lariat.net>
Cc: 
Subject: Re: bin/130159: [patch] ppp(8) fails to correctly set routes
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Brett Glass <brett@lariat.net>
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Apr 2009 14:30:04 -0000

The following reply was made to PR bin/130159; it has been noted by GNATS.

From: Brett Glass <brett@lariat.net>
To: "Luiz Otavio O Souza" <loos.br@gmail.com>, "Qing Li" <qingli@freebsd.org>,
        <bug-followup@freebsd.org>
Cc:  
Subject: Re: bin/130159: [patch] ppp(8) fails to correctly set routes
Date: Mon, 13 Apr 2009 08:20:40 -0600

 At 06:01 AM 4/13/2009, Luiz Otavio O Souza wrote:
 
 >>Note: With the patch as written, the "gateway" (G) flag is set in 
 >>the routing table entry. This does not seem to cause problems, 
 >>but the flag should not be set because the "tun" interface is 
 >>acting as a bridge, not a gateway.
 >
 >Brett,
 >
 >This patch doesn't fix or change the gateway flag, it only set the 
 >interface in route update message.
 >
 >The gateway problem was fixed in r186308 by Qing Li 
 >(http://svn.freebsd.org/viewvc/base/head/usr.sbin/ppp/route.c?sortdir=down&r1=186119&r2=186308&sortby=rev 
 >- check the commit log)
 >
 >Thanks,
 >Luiz
 
 Luiz, Qing Li's patch must not have made it into 7.1-RELEASE, 
 because I had to apply it manually. All three patches (your two 
 plus Qing Li's) should be committed and MFCed before 7.2-RELEASE, 
 because we (and others, I'm sure) really need PPP to work properly.
 
 --Brett Glass