From owner-freebsd-threads@FreeBSD.ORG  Wed Oct  8 19:11:17 2008
Return-Path: <owner-freebsd-threads@FreeBSD.ORG>
Delivered-To: freebsd-threads@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 539F2106569B
	for <freebsd-threads@freebsd.org>; Wed,  8 Oct 2008 19:11:17 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
	[IPv6:2001:470:1f10:75::2])
	by mx1.freebsd.org (Postfix) with ESMTP id CC0788FC1E
	for <freebsd-threads@freebsd.org>; Wed,  8 Oct 2008 19:11:16 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1])
	(authenticated bits=0)
	by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m98JB4tV057790;
	Wed, 8 Oct 2008 15:11:10 -0400 (EDT) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-threads@freebsd.org
Date: Wed, 8 Oct 2008 14:09:31 -0400
User-Agent: KMail/1.9.7
References: <18668.10465.699531.162573@gromit.timing.com>
In-Reply-To: <18668.10465.699531.162573@gromit.timing.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200810081409.31822.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]);
	Wed, 08 Oct 2008 15:11:10 -0400 (EDT)
X-Virus-Scanned: ClamAV 0.93.1/8395/Wed Oct 8 12:44:51 2008 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-2.4 required=4.2 tests=AWL,BAYES_00,NO_RELAYS 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: John Hein <jhein@timing.com>
Subject: Re: pthread_cleanup_push & pthread_cleanup_pop usage
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>, 
	<mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-threads>,
	<mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Oct 2008 19:11:17 -0000

On Tuesday 07 October 2008 11:28:33 pm John Hein wrote:
> In June pthread_cleanup_push & pthread_cleanup_pop were changed to macros
> that look like so...
> 
> +#define        pthread_cleanup_push(cleanup_routine, cleanup_arg)              
\
> +               {                                                               
\
> +                       struct _pthread_cleanup_info __cleanup_info__;          
\
> +                       __pthread_cleanup_push_imp(cleanup_routine, 
cleanup_arg,\
> +                               &__cleanup_info__);                             
\
> +                       {
> +
> +#define        pthread_cleanup_pop(execute)                                    
\
> +                       }                                                       
\
> +                       __pthread_cleanup_pop_imp(execute);                     
\
> +               }
> +
> 
> 
> This breaks code where the pop is done in an inner block level.
> 
> simplified example:
> 
>     pthread_cleanup_push(docleanup, &foo);
>     try
>     {   
>         dostuff();
>     }
>     catch (...)
>     {   
>         pthread_cleanup_pop(1);
>         throw;
>     }
>     pthread_cleanup_pop(1);
> 
> Does anyone have a recommended fix?

Don't Do That (tm).  The spec explicitly states that they can be defined as 
macros and that code using it needs to put them in the same block.

-- 
John Baldwin