Date: Sun, 23 Apr 2006 20:50:18 -0700 (PDT) From: Jeremy Chadwick <freebsd@jdc.parodius.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/96244: graphics/png -- update for NO_OBJ and NO_PROFILE Message-ID: <20060424035018.D0EFF5E33@mx1.parodius.com> Resent-Message-ID: <200604240400.k3O40cWY003574@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 96244
>Category: ports
>Synopsis: graphics/png -- update for NO_OBJ and NO_PROFILE
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Apr 24 04:00:38 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Jeremy Chadwick
>Release: FreeBSD 4.11-STABLE i386
>Organization:
Parodius Networking
>Environment:
System: FreeBSD pentarou.parodius.com 4.11-STABLE FreeBSD 4.11-STABLE #0: Thu Jan 12 01:50:11 PST 2006 root@pentarou.parodius.com:/usr/obj/usr/src/sys/PENTAROU i386
>Description:
Please ignore the release/environment for this PR; source system
is actually 6.1-RC.
Building libpng results in the following legitimate warnings:
===> Patching for png-1.2.8_3
===> Applying FreeBSD patches for png-1.2.8_3
===> Configuring for png-1.2.8_3
===> Building for png-1.2.8_3
"/usr/share/mk/bsd.compat.mk", line 36: warning: NOOBJ is deprecated in favor of NO_OBJ
"/usr/share/mk/bsd.compat.mk", line 36: warning: NOPROFILE is deprecated in favor of NO_PROFILE
This is caused by ${WRKSRC}/scripts/makefile.freebsd using the old
NOOBJ and NOPROFILE nomenclature.
files/patch-aa already tinkers with makefile.freebsd, so it would be
best to update files/patch-aa to include a fix for this. Below is a
patch to files/patch-aa.
>How-To-Repeat:
Build libpng on a system which uses the new NO_OBJ/NO_PROFILE tweaks.
>Fix:
Apply the below patch to files/patch-aa. If this doesn't work, let
me know and I can provide the full files/patch-aa replacement.
--- patch-aa.orig Thu Feb 9 00:53:05 2006
+++ patch-aa Sun Apr 23 20:43:34 2006
@@ -1,7 +1,13 @@
---- scripts/makefile.freebsd.orig Sat May 18 08:46:45 2002
-+++ scripts/makefile.freebsd Tue Jan 10 12:05:18 2006
-@@ -12,22 +12,22 @@
- NOOBJ= YES
+--- makefile.freebsd.orig Sat May 18 07:46:45 2002
++++ makefile.freebsd Sun Apr 23 20:43:10 2006
+@@ -8,26 +8,26 @@
+ LIB= png
+ SHLIB_MAJOR= ${SHLIB_VER}
+ SHLIB_MINOR= 0
+-NOPROFILE= YES
+-NOOBJ= YES
++NO_PROFILE= YES
++NO_OBJ= YES
# where make install puts libpng.a and png.h
-DESTDIR= ${PREFIX}
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060424035018.D0EFF5E33>