From owner-freebsd-bugs@FreeBSD.ORG Fri Mar 26 20:03:01 2004 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D042B16A4CE for ; Fri, 26 Mar 2004 20:03:01 -0800 (PST) Received: from mtaw4.prodigy.net (mtaw4.prodigy.net [64.164.98.52]) by mx1.FreeBSD.org (Postfix) with ESMTP id AAD9443D31 for ; Fri, 26 Mar 2004 20:03:01 -0800 (PST) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (96fe54d06a46ace617a9af53f115791a@adsl-67-115-73-128.dsl.lsan03.pacbell.net [67.115.73.128]) by mtaw4.prodigy.net (8.12.10/8.12.10) with ESMTP id i2R42vfG002837; Fri, 26 Mar 2004 20:02:58 -0800 (PST) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id DB53F5131A; Fri, 26 Mar 2004 20:02:56 -0800 (PST) Date: Fri, 26 Mar 2004 20:02:56 -0800 From: Kris Kennaway To: Giorgos Keramidas Message-ID: <20040327040256.GA95621@xor.obsecurity.org> References: <200403261523.i2QFNhGS044804@gothmog.gr> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="HcAYCG3uE/tztfnV" Content-Disposition: inline In-Reply-To: <200403261523.i2QFNhGS044804@gothmog.gr> User-Agent: Mutt/1.4.2.1i cc: freebsd-bugs@freebsd.org Subject: Re: fetchmail-6.2.5 bug in FreeBSD-current X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Mar 2004 04:03:01 -0000 --HcAYCG3uE/tztfnV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 26, 2004 at 05:23:43PM +0200, Giorgos Keramidas wrote: > I'm in the middle of reinstalling all my ports/packages, after an > upgrade to today's current and I just happened to notice a minor bug > that breaks the POP3 protocol in version 6.2.5 of fetchmail. >=20 > The error message that pointed me to the direction of the bug is marked > below with an arrow: >=20 > giorgos@gothmog[17:05]/home/giorgos$ fetchmail -v -v -v -a -K | more > fetchmail: 6.2.5 querying igloo.linux.gr (protocol APOP) at Fri Mar 2= 6 17:05:31 2004: poll started > fetchmail: POP3< +OK Qpopper (version 4.0.5) at igloo.linux.gr starti= ng. <21364.1080313531@igloo.linux.gr> > fetchmail: POP3> APOP keramida d0d69aaea3370f3bc50c60a6aac5c088 > fetchmail: POP3< +OK keramida has 59 visible messages (0 hidden) in 2= 97764 octets. > fetchmail: POP3> STAT > fetchmail: POP3< +OK 59 297764 > 59 messages for keramida at igloo.linux.gr (297764 octets). > -> fetchmail: cannot get a range of message sizes (1-59). > fetchmail: POP3> QUIT > fetchmail: POP3< +OK Pop server at igloo.linux.gr signing off. >=20 > Apparently, a check in pop3.c uses reverse logic. Fixing fetchmail here > required changing the following (in a patch-zz-local that I added to the > port's files/ subdir): >=20 > %% > --- pop3.c.orig Fri Mar 26 17:08:39 2004 > +++ pop3.c Fri Mar 26 17:08:12 2004 > @@ -916,7 +916,7 @@ > unsigned int num, size; > =20 > /* for POP3, we can get the size of one mail only! */ > - if (first !=3D last) > + if (first =3D=3D last) > { > report(stderr, "cannot get a range of message sizes (%d-%d).\n", first,= last); > return(PS_PROTOCOL); > %% >=20 > Has anyone else seen/fixed this problem with version 6.2.5 or am I just > doing silly, ignorant things here? I've tried to report this to the fetchmail authors since last year, and (when their mailing list was not misconfigured and rejecting emails) have been unable to get a response. I'm not sure your patch is correct though - the check itself seems to be correct ("Are we trying to fetch a range of messages?"), it's the need for the check itself that seems broken. Kris --HcAYCG3uE/tztfnV Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAZPzwWry0BWjoQKURApibAJ9U7mJVpuceO7lxohWcDaPJhOjQHwCgoSpy CnwGzk08C836LF8pCxYU2Yc= =OfRl -----END PGP SIGNATURE----- --HcAYCG3uE/tztfnV--