Date: Fri, 26 Mar 2004 20:02:56 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Giorgos Keramidas <keramida@ceid.upatras.gr> Cc: freebsd-bugs@freebsd.org Subject: Re: fetchmail-6.2.5 bug in FreeBSD-current Message-ID: <20040327040256.GA95621@xor.obsecurity.org> In-Reply-To: <200403261523.i2QFNhGS044804@gothmog.gr> References: <200403261523.i2QFNhGS044804@gothmog.gr>
next in thread | previous in thread | raw e-mail | index | archive | help
--HcAYCG3uE/tztfnV
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Mar 26, 2004 at 05:23:43PM +0200, Giorgos Keramidas wrote:
> I'm in the middle of reinstalling all my ports/packages, after an
> upgrade to today's current and I just happened to notice a minor bug
> that breaks the POP3 protocol in version 6.2.5 of fetchmail.
>=20
> The error message that pointed me to the direction of the bug is marked
> below with an arrow:
>=20
> giorgos@gothmog[17:05]/home/giorgos$ fetchmail -v -v -v -a -K | more
> fetchmail: 6.2.5 querying igloo.linux.gr (protocol APOP) at Fri Mar 2=
6 17:05:31 2004: poll started
> fetchmail: POP3< +OK Qpopper (version 4.0.5) at igloo.linux.gr starti=
ng. <21364.1080313531@igloo.linux.gr>
> fetchmail: POP3> APOP keramida d0d69aaea3370f3bc50c60a6aac5c088
> fetchmail: POP3< +OK keramida has 59 visible messages (0 hidden) in 2=
97764 octets.
> fetchmail: POP3> STAT
> fetchmail: POP3< +OK 59 297764
> 59 messages for keramida at igloo.linux.gr (297764 octets).
> -> fetchmail: cannot get a range of message sizes (1-59).
> fetchmail: POP3> QUIT
> fetchmail: POP3< +OK Pop server at igloo.linux.gr signing off.
>=20
> Apparently, a check in pop3.c uses reverse logic. Fixing fetchmail here
> required changing the following (in a patch-zz-local that I added to the
> port's files/ subdir):
>=20
> %%
> --- pop3.c.orig Fri Mar 26 17:08:39 2004
> +++ pop3.c Fri Mar 26 17:08:12 2004
> @@ -916,7 +916,7 @@
> unsigned int num, size;
> =20
> /* for POP3, we can get the size of one mail only! */
> - if (first !=3D last)
> + if (first =3D=3D last)
> {
> report(stderr, "cannot get a range of message sizes (%d-%d).\n", first,=
last);
> return(PS_PROTOCOL);
> %%
>=20
> Has anyone else seen/fixed this problem with version 6.2.5 or am I just
> doing silly, ignorant things here?
I've tried to report this to the fetchmail authors since last year,
and (when their mailing list was not misconfigured and rejecting
emails) have been unable to get a response.
I'm not sure your patch is correct though - the check itself seems to
be correct ("Are we trying to fetch a range of messages?"), it's the
need for the check itself that seems broken.
Kris
--HcAYCG3uE/tztfnV
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAZPzwWry0BWjoQKURApibAJ9U7mJVpuceO7lxohWcDaPJhOjQHwCgoSpy
CnwGzk08C836LF8pCxYU2Yc=
=OfRl
-----END PGP SIGNATURE-----
--HcAYCG3uE/tztfnV--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040327040256.GA95621>