Date: Fri, 1 Aug 2014 06:20:47 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: marino@freebsd.org Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, Max Brazhnikov <makc@freebsd.org>, Antoine Brodin <antoine@FreeBSD.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, William Grzybowski <wg@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, Mathieu Arnold <mat@freebsd.org>, Adam Weinberger <adamw@adamw.org> Subject: Re: svn commit: r363361 - in head/editors/fte: . files Message-ID: <20140801062047.GC71116@FreeBSD.org> In-Reply-To: <53DB3021.7010909@marino.st> References: <2D24420529C9ECAEABB9A791@atuin.in.mat.cc> <53D8A2BB.7090704@marino.st> <6270029E710D3C52B60B6224@atuin.in.mat.cc> <20140730081413.GA29876@FreeBSD.org> <20140730160843.GA2688@FreeBSD.org> <53D919BC.6010307@marino.st> <20140801051652.GA59625@FreeBSD.org> <CAALwa8=R2i9PA7R8VXHStZCDGy_ZFaYcBtRmY-_ZFq9k=toJ%2Bw@mail.gmail.com> <20140801060506.GA71116@FreeBSD.org> <53DB3021.7010909@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 01, 2014 at 08:13:53AM +0200, John Marino wrote:
> logic flaw: You can't just replace "/" with "-" or "_" without altering
> "-" or "_" in the filename.
>
> example, given these files:
> ${WRKSRC}/alpha-bravo
> ${WRKSRC}/alpha/bravo
>
> if you replace "/" with "-", both have the same suggested patch name.
> You need to alter the hyphen in alpha-bravo first.
Basically right now one patch will overwrite another conflicting one, which
ever comes first. I think I can add a check beforea > $${OUT} and issue an
error and refuse to overwrite a file, or maybe just warn. Which you prefer?
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140801062047.GC71116>