From owner-freebsd-scsi Sun Apr 29 10: 0:17 2001 Delivered-To: freebsd-scsi@freebsd.org Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by hub.freebsd.org (Postfix) with ESMTP id 6AC1E37B440 for ; Sun, 29 Apr 2001 10:00:09 -0700 (PDT) (envelope-from j@uriah.heep.sax.de) Received: (from uucp@localhost) by sax.sax.de (8.9.3/8.9.3) with UUCP id TAA04792 for freebsd-scsi@FreeBSD.ORG; Sun, 29 Apr 2001 19:00:08 +0200 (CEST) Received: (from j@localhost) by uriah.heep.sax.de (8.11.3/8.11.3) id f3TGrrs30690 for freebsd-scsi@FreeBSD.ORG; Sun, 29 Apr 2001 18:53:53 +0200 (MET DST) (envelope-from j) Date: Sun, 29 Apr 2001 18:53:53 +0200 From: J Wunsch To: freebsd-scsi@FreeBSD.ORG Subject: Re: Another problem with the new CAM error handling Message-ID: <20010429185353.C50185@uriah.heep.sax.de> Reply-To: Joerg Wunsch References: <20010426110542.A50185@uriah.heep.sax.de> <200104261435.f3QEZLs23573@aslan.scsiguy.com> <20010426190714.E50185@uriah.heep.sax.de> <20010428231227.A37369@panzer.kdm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0.1i In-Reply-To: <20010428231227.A37369@panzer.kdm.org>; from ken@kdm.org on Sat, Apr 28, 2001 at 11:12:27PM -0600 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Sender: owner-freebsd-scsi@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org As Kenneth D. Merry wrote: > The old code retried unit attentions unconditionally without decrementing > the retry count if SF_RETRY_UA was set. If SF_RETRY_UA wasn't set, it > would still retry unit attentions, but would decrement the retry count. Ah, yes, that would explain it. Thanks for the analyzation, i didn't get a grip about it when looking at the code. > The attached patch should fix your problem. OK, i'll test that. > A better name might be 'camcontrol detach'. You're right, such an option > might help with reviving dead peripherals. Hopefully we can make things > robust enough so that a peripheral isn't declared "dead" unless it really > is dead. I think there's always a chance that something is being misdetected as `dead' when you can actually revive it somehow. Would it be much work to implement a "camcontrol detach"? Also, i'd like to prefer that over issuing a bus reset in case a temporarily added SCSI device is being manually removed. > ! start_ccb->ccb_h.ccb_state = PT_CCB_BUFFER_IO; ... > ! start_ccb->ccb_h.ccb_state = PT_CCB_BUFFER_IO_UA; Well, it's _that_ simple, ain't it? :-) -- cheers, J"org .-.-. --... ...-- -.. . DL8DTL http://www.sax.de/~joerg/ NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message