From owner-freebsd-hackers@FreeBSD.ORG  Tue Nov  3 07:26:20 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 32AE3106566B;
	Tue,  3 Nov 2009 07:26:20 +0000 (UTC)
	(envelope-from rea-fbsd@codelabs.ru)
Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.177.45])
	by mx1.freebsd.org (Postfix) with ESMTP id D77198FC14;
	Tue,  3 Nov 2009 07:26:19 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=codelabs.ru; s=two; h=Date:From:To:Cc:Subject:Message-ID:
	Reply-To:References:MIME-Version:Content-Type:In-Reply-To:
	Sender; bh=QPgcj/kYW2RPidaKdsYUhCmxL9cQRMAfl6VW9Tefu0U=; b=EDjew
	JztQMrgKNFqnPvUWxVn4AYS2eRuUNCmAVp4Ly37/Rsx1ImcyKdKgCYur90NJHCUn
	e1ZM1B3ODgMzqdy7Em8P8GSDlcUyzQA7ZGUIt99yxzE97rX3YxUFytRO+TqerQp6
	c71X67NcFApb6cqd9xrf7TQpGF8wNnmfN5yU1EKy6xQJKTeUs7jKlMGlhpmWkZos
	yKejC6txuV9p5K8oA9++DyiBa5dWPIgC4N/5LDKq64hS8z4B9ijSe7MMcWGOM2v8
	iaF7GBkaD5ZMJ4dajVP+Eu/qk89D130yGMNQq9bd37xc+Hb8xvnpmZ+mhA5iXwAY
	BloCxgAAPSyyh1mrA==
Received: from void.codelabs.ru (void.codelabs.ru [144.206.177.25])
	by 0.mx.codelabs.ru with esmtpsa (TLSv1:AES256-SHA:256)
	id 1N5DmS-0009uC-0G; Tue, 03 Nov 2009 10:26:16 +0300
Date: Tue, 3 Nov 2009 10:26:12 +0300
From: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
To: Alexander Best <alexbestms@math.uni-muenster.de>
Message-ID: <Uzn3rwzsWEtTrYaz4Wl3Xnqcm9I@SNwcwk2DeGhgeFqjLEiQrEAOiKg>
References: <86bpjmkxre.fsf@ds4.des.no>
	<permail-2009110221322980e26a0b00005a91-a_best01@message-id.uni-muenster.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <permail-2009110221322980e26a0b00005a91-a_best01@message-id.uni-muenster.de>
Sender: rea-fbsd@codelabs.ru
Cc: Ed Schouten <ed@80386.nl>, freebsd-hackers@freebsd.org,
	pluknet <pluknet@gmail.com>, Antony Mawer <lists@mawer.org>,
	Dag-Erling Sm?rgrav <des@des.no>, rafan@freebsd.org
Subject: Re: help needed to fix contrib/ee crash/exit when receiving SIGWINCH
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: rea-fbsd@codelabs.ru
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Nov 2009 07:26:20 -0000

Mon, Nov 02, 2009 at 10:32:29PM +0100, Alexander Best wrote:
> ok. the pr stays in patched state. right now the patch is in HEAD,
> 8-STABLE and 8.0-RELEASE. rafan is thinking about mfc'ing the patch to
> 6-stable and 7-stable. however if somebody is willing to modify the
> patch so it applies to those branches that'll be great

Patch applies cleanly to the 7-STABLE, moreover, lib_getch.c from it
has the same logics and fifo_push is essentially unmodified in the
areas that are relevant for this flaw.

I had patched 7-STABLE on the test machine, brought ee from 8.x and
verified that unpatched ncurses give immediate exit, while patched
curses give working ee in respect to the SIGWINCH.

I had also mildly tested vi and sysinstall on the patched 7-STABLE
and found no visible regressions.
-- 
Eygene
 _                ___       _.--.   #
 \`.|\..----...-'`   `-._.-'_.-'`   #  Remember that it is hard
 /  ' `         ,       __.--'      #  to read the on-line manual
 )/' _/     \   `-_,   /            #  while single-stepping the kernel.
 `-'" `"\_  ,_.-;_.-\_ ',  fsc/as   #
     _.-'_./   {_.'   ; /           #    -- FreeBSD Developers handbook
    {_.-``-'         {_/            #