From owner-freebsd-stable@FreeBSD.ORG Tue Feb 2 21:39:07 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0151C106566B; Tue, 2 Feb 2010 21:39:07 +0000 (UTC) (envelope-from jfvogel@gmail.com) Received: from mail-ww0-f54.google.com (mail-ww0-f54.google.com [74.125.82.54]) by mx1.freebsd.org (Postfix) with ESMTP id 338AA8FC1B; Tue, 2 Feb 2010 21:39:05 +0000 (UTC) Received: by wwj40 with SMTP id 40so46069wwj.13 for ; Tue, 02 Feb 2010 13:39:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=z1zhJj3ky+cQaLCy7i4IQkULiRjdrKl0x3x4y3oaPVo=; b=MRpoC+6FcOtpSV7Nn2b/rpLqYzQLkLja28+1tYBJ5NR4lx/4+WcuoDpOdoc2CgyPaC Fe9ymgTAAsTO1MtUSmDSH34Roz31EuMCLqdsJcKLdabNUVoJxHzMG0cerqnq1e/yMtBw 4W6FsXf6RqfHi7zcY3H25zo+14O5NR/HfDYrI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=w2FnjrOrZieNSPp8QqbI4fVpkJbH6kBpioRD5ePuFu5uk4wqZH7U0ZQcBaH43Uy+qL jNHlQJNXjUeDoM5rB5q/T/GVOPnatWX1bTdRoNt0KFUb8ikOIaLqGjrgMHMY3lnRhGho 61ZkNSyEKrRnRQqcH5072VhY8S/QQIsWQKTtA= MIME-Version: 1.0 Received: by 10.216.87.20 with SMTP id x20mr960621wee.158.1265146745045; Tue, 02 Feb 2010 13:39:05 -0800 (PST) In-Reply-To: <201002022137.52064.max@love2party.net> References: <147432021001310037n1b67f01bx4b4e8781321cea8@mail.gmail.com> <20100202173746.GA5901@michelle.cdnetworks.com> <2a41acea1002020948l6f3d1a08v9f4ccefd1241f566@mail.gmail.com> <201002022137.52064.max@love2party.net> Date: Tue, 2 Feb 2010 13:39:04 -0800 Message-ID: <2a41acea1002021339i3801fc4bw736fa01188f60290@mail.gmail.com> From: Jack Vogel To: Max Laier Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: pyunyh@gmail.com, Nick Rogers , stable@freebsd.org, freebsd-stable@freebsd.org, jfv@freebsd.org Subject: Re: em(4) + ALTQ broken X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Feb 2010 21:39:07 -0000 Thanks Max, yes, i've done some digging myself and now see how things work, the rubber meets the road in the defines in if_var.h. And what it does is effectively short circuit Kip Macy's multiqueue code in favor of the old method. Right now I can see two possibilities, either the defines are not set in the build, OR there is something wrong in the logic of the short circuit approach in Kip's code. A question might be if ANY driver that is usinig TX Multiqueue has been successfully used with ALTQ? Jack On Tue, Feb 2, 2010 at 12:37 PM, Max Laier wrote: > On Tuesday 02 February 2010 18:48:02 Jack Vogel wrote: > > So apparently this thing needs no special knowledge in the driver, yet > > something in > > the new code breaks it, can someone explain tersely how the altq app > > actually > > "pokes" or "hooks up" to the driver? I am not clear about that and I > > suspect if I was > > this would all be clearer. > > The whole story is in > > man 9 altq > > long story short, as long as you consistently use the IFQ_* macros to > manage > the interface queue, things should just work. if_var.h used to > conditionally > define these macros to avoid ALTQ overhead when the kernel is built without > ALTQ. This has changed a long time ago and should not make any difference > anymore. > > I can't figure out who the OP is, but could you make sure that the includes > that are used to built the kernel are up to date? You are building with > the > buildkernel target and not "the old way", right? Also, if you build just > the > module, the build might pick up the includes from /usr/include instead of > src/sys ... > > > Jack > > > > On Tue, Feb 2, 2010 at 9:37 AM, Pyun YongHyeon wrote: > > > On Tue, Feb 02, 2010 at 09:30:52AM -0800, Nick Rogers wrote: > > > > > I guess the problem comes from multi-queue support. The drbr > > > > > interface is implemented with inline function so em(4)/igb(4) may > > > > > have to define ALTQ to the header. I have not tested the patch(no > > > > > time at this moment) but would you give it try? > > > > > > > > > > I tried the patch and it did not work. > > > > > > You rebuilt kernel, right? Rebuilding kernel module has no effect. > > > > _______________________________________________ > > freebsd-stable@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-stable > > To unsubscribe, send any mail to "freebsd-stable-unsubscribe@freebsd.org > " > > > > > > !DSPAM:4b686584144321871135632! > > >