Date: Sat, 13 Jul 2024 06:11:04 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Mathieu Arnold <mat@FreeBSD.org> Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org, Baptiste Daroussin <bapt@freebsd.org> Subject: Re: git: 06601897e5cd - main - framework: reintroduce the feature enabling code Message-ID: <12af8e210220224883a7856115f61be9@mail.infomaniak.com> In-Reply-To: <202404120754.43C7slbr026326@gitrepo.freebsd.org> References: <202404120754.43C7slbr026326@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--_=_swift_1720843864_ee7b271ff312a5e000ad236f2a163824_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-04-12T09:54:47.000+02:00, Mathieu Arnold <mat@FreeBSD.org> wrote:= >=C2=A0The=C2=A0branch=C2=A0main=C2=A0has=C2=A0been=C2=A0updated= =C2=A0by=C2=A0mat: >=C2=A0 >=C2=A0URL:=C2=A0https://cgit.FreeBSD.org/po= rts/commit/?id=3D06601897e5cd4afcc31f3b508b2cbb2bc7d4a677 >=C2=A0 >= =C2=A0commit=C2=A006601897e5cd4afcc31f3b508b2cbb2bc7d4a677 >=C2=A0 >= =C2=A0Author:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Mathieu=C2=A0Arnold=C2=A0<mat@Fr= eeBSD.org> >=C2=A0 >=C2=A0AuthorDate:=C2=A02024-04-12=C2=A007:49:01= =C2=A0+0000 >=C2=A0 >=C2=A0Commit:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Mathieu= =C2=A0Arnold=C2=A0<mat@FreeBSD.org> >=C2=A0 >=C2=A0CommitDate:=C2=A0202= 4-04-12=C2=A007:53:27=C2=A0+0000 >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0framework:=C2=A0reintroduce=C2=A0the=C2=A0feature=C2=A0enabling=C2= =A0code >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0For=C2=A0each=C2=A0feature=C2=A0(see=C2=A0in=C2= =A0Mk/Features)=C2=A0users=C2=A0can=C2=A0now=C2=A0set=C2=A0these=C2=A0varia= bles >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0in=C2=A0their=C2=A0make.con= f.=C2=A0Using=C2=A0LTO=C2=A0as=C2=A0an=C2=A0example. >=C2=A0 >=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0To= =C2=A0enable=C2=A0globally: >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >= =C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0WITH_LTO=3D=C2=A0yes = >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0To=C2=A0disable=C2=A0globally=C2=A0(for=C2=A0example=C2= =A0ssp=C2=A0is=C2=A0enabled=C2=A0by=C2=A0default): >=C2=A0 >=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0WITHOUT_LTO=3D=C2=A0=C2=A0yes >=C2=A0 >=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0To=C2=A0enable= =C2=A0for=C2=A0a=C2=A0specific=C2=A0list=C2=A0of=C2=A0ports: >=C2=A0 >= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0WITH_LTO_PORTS=3D=C2=A0lang/perl5.36 >=C2=A0 >=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0To= =C2=A0disable=C2=A0for=C2=A0a=C2=A0specific=C2=A0list=C2=A0of=C2=A0ports:= >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0WITHOUT_LTO_PORTS=3D=C2=A0lang/perl5.36 >= =C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0Differential=C2=A0Revision:=C2=A0=C2=A0https://reviews.freebsd.= org/D44750 >=C2=A0 >=C2=A0--- >=C2=A0 >=C2=A0=C2=A0Mk/Uses/cargo.mk= =C2=A0[http://cargo.mk]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0|=C2=A0=C2=A04=C2=A0+--- >=C2=A0 >=C2=A0=C2=A0Mk/bsd.= port.mk=C2=A0[http://bsd.port.mk]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A042=C2=A0+++++++++++++++++++++= +++++++++++++-------- >=C2=A0 >=C2=A0=C2=A0net-mgmt/net-snmp/Makefile= =C2=A0|=C2=A0=C2=A02=C2=A0+- >=C2=A0 >=C2=A0=C2=A03=C2=A0files=C2=A0cha= nged,=C2=A036=C2=A0insertions(+),=C2=A012=C2=A0deletions(-) >=C2=A0 >= =C2=A0diff=C2=A0--git=C2=A0a/Mk/Uses/cargo.mk=C2=A0[http://cargo.mk]=C2= =A0b/Mk/Uses/cargo.mk=C2=A0[http://cargo.mk] >=C2=A0 >=C2=A0index=C2= =A0e3b733d35821..8710374e3584=C2=A0100644 >=C2=A0 >=C2=A0---=C2=A0a/Mk/= Uses/cargo.mk=C2=A0[http://cargo.mk] >=C2=A0 >=C2=A0+++=C2=A0b/Mk/Uses/= cargo.mk=C2=A0[http://cargo.mk] >=C2=A0 >=C2=A0@@=C2=A0-139,10=C2=A0+13= 9,8=C2=A0@@=C2=A0CARGO_ENV+=3D=C2=A0\ >=C2=A0 >=C2=A0=C2=A0CARGO_ENV+= =3D=C2=A0=C2=A0=C2=A0=C2=A0RUST_BACKTRACE=3D1 >=C2=A0 >=C2=A0=C2=A0.= =C2=A0=C2=A0endif >=C2=A0 >=C2=A0=C2=A0 >=C2=A0 >=C2=A0-.=C2=A0= =C2=A0if=C2=A0!defined(_WITHOUT_LTO)=C2=A0&&=C2=A0(!defined(WITHOUT_LTO_POR= TS)=C2=A0||=C2=A0${WITHOUT_LTO_PORTS:N${PKGORIGIN}}) >=C2=A0 >=C2=A0+.= =C2=A0=C2=A0if=C2=A0defined(WITH_LTO) >=C2=A0 >=C2=A0=C2=A0_CARGO_MSG= =3D=C2=A0=C2=A0=C2=A0=C2=A0"=3D=3D=3D>=C2=A0=C2=A0=C2=A0Additional=C2=A0opt= imization=C2=A0to=C2=A0port=C2=A0applied" >=C2=A0 >=C2=A0-_WITH_LTO=3D= =C2=A0=C2=A0=C2=A0=C2=A0yes >=C2=A0 >=C2=A0-.undef=C2=A0_WITHOUT_LTO = >=C2=A0 >=C2=A0=C2=A0.=C2=A0=C2=A0endif=C2=A0 Hi, This changes = so LTO option is no longer applied to Rust (cargo) ports BY DEFAULT causi= ng a regresssion, please fix. Best regards, Daniel --_=_swift_1720843864_ee7b271ff312a5e000ad236f2a163824_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><body><div>On 2024-04-12T09:54:47.000+02:00, Mathieu Arnold <mat@F= reeBSD.org> wrote:<br></div><div ><div><br></div></div><div class=3D"ik_= mail_quote answerContentMessage"><blockquote class=3D"ws-ng-quote"><pre sty= le=3D"white-space: normal;"><div>The branch main has been updated by mat:<b= r></div><div><br></div><div>URL: <a data-ik=3D"ik-secure" rel=3D"noopener n= oreferrer" class=3D"defaultMailLink" href=3D"https://cgit.FreeBSD.org/ports= /commit/?id=3D06601897e5cd4afcc31f3b508b2cbb2bc7d4a677" target=3D"_blank">h= ttps://cgit.FreeBSD.org/ports/commit/?id=3D06601897e5cd4afcc31f3b508b2cbb2b= c7d4a677</a><br></div><div><br></div><div>commit 06601897e5cd4afcc31f3b508b= 2cbb2bc7d4a677<br></div><div>Author: Mathieu Arnold <<a class=3D"def= aultMailLink" href=3D"mailto:mat@FreeBSD.org">mat@FreeBSD.org</a>><br></= div><div>AuthorDate: 2024-04-12 07:49:01 +0000<br></div><div>Commit: Ma= thieu Arnold <<a class=3D"defaultMailLink" href=3D"mailto:mat@FreeBSD.or= g">mat@FreeBSD.org</a>><br></div><div>CommitDate: 2024-04-12 07:53:27 +0= 000<br></div><div><br></div><div> framework: reintroduce the feature ena= bling code<br></div><div> <br></div><div> For each feature (see in Mk= /Features) users can now set these variables<br></div><div> in their mak= e.conf. Using LTO as an example.<br></div><div> <br></div><div> To en= able globally:<br></div><div> <br></div><div> WITH_LTO=3D yes<br></= div><div> <br></div><div> To disable globally (for example ssp is ena= bled by default):<br></div><div> <br></div><div> WITHOUT_LTO=3D ye= s<br></div><div> <br></div><div> To enable for a specific list of por= ts:<br></div><div> <br></div><div> WITH_LTO_PORTS=3D lang/perl5.36<= br></div><div> <br></div><div> To disable for a specific list of port= s:<br></div><div> <br></div><div> WITHOUT_LTO_PORTS=3D lang/perl5.3= 6<br></div><div> <br></div><div> Differential Revision: <a data-ik= =3D"ik-secure" rel=3D"noopener noreferrer" class=3D"defaultMailLink" href= =3D"https://reviews.freebsd.org/D44750" target=3D"_blank">https://reviews.f= reebsd.org/D44750</a><br></div><div>---<br></div><div> Mk/Uses/<a data-ik= =3D"ik-secure" rel=3D"noopener noreferrer" class=3D"defaultMailLink" href= =3D"http://cargo.mk" target=3D"_blank">cargo.mk</a> | 4 +---<br>= </div><div> Mk/<a data-ik=3D"ik-secure" rel=3D"noopener noreferrer" class= =3D"defaultMailLink" href=3D"http://bsd.port.mk" target=3D"_blank">bsd.port= .mk</a> | 42 ++++++++++++++++++++++++++++++++++--------<br></di= v><div> net-mgmt/net-snmp/Makefile | 2 +-<br></div><div> 3 files changed, = 36 insertions(+), 12 deletions(-)<br></div><div><br></div><div>diff --git a= /Mk/Uses/<a data-ik=3D"ik-secure" rel=3D"noopener noreferrer" class=3D"defa= ultMailLink" href=3D"http://cargo.mk" target=3D"_blank">cargo.mk</a> b/Mk/U= ses/<a data-ik=3D"ik-secure" rel=3D"noopener noreferrer" class=3D"defaultMa= ilLink" href=3D"http://cargo.mk" target=3D"_blank">cargo.mk</a><br></div><d= iv>index e3b733d35821..8710374e3584 100644<br></div><div>--- a/Mk/Uses/<a d= ata-ik=3D"ik-secure" rel=3D"noopener noreferrer" class=3D"defaultMailLink" = href=3D"http://cargo.mk" target=3D"_blank">cargo.mk</a><br></div><div>+++ b= /Mk/Uses/<a data-ik=3D"ik-secure" rel=3D"noopener noreferrer" class=3D"defa= ultMailLink" href=3D"http://cargo.mk" target=3D"_blank">cargo.mk</a><br></d= iv><div>@@ -139,10 +139,8 @@ CARGO_ENV+=3D \<br></div><div> CARGO_ENV+=3D= =09RUST_BACKTRACE=3D1<br></div><div> . endif<br></div><div> <br></div><div= >-. if !defined(_WITHOUT_LTO) && (!defined(WITHOUT_LTO_PORTS) || $= {WITHOUT_LTO_PORTS:N${PKGORIGIN}})<br></div><div>+. if defined(WITH_LTO)<b= r></div><div> _CARGO_MSG=3D=09"=3D=3D=3D> Additional optimization to p= ort applied"<br></div><div>-_WITH_LTO=3D=09yes<br></div><div>-.undef _WITHO= UT_LTO<br></div><div> . endif <br></div></pre></blockquote></div><div>Hi,<= br></div><div><br></div><div>This changes so LTO option is no longer applie= d to Rust (cargo) ports BY DEFAULT causing a regresssion, please fix.<br></= div><div><br></div><div>Best regards,<br></div><div>Daniel<br></div></body>= </html> --_=_swift_1720843864_ee7b271ff312a5e000ad236f2a163824_=_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?12af8e210220224883a7856115f61be9>