From owner-freebsd-ports@FreeBSD.ORG  Fri Apr 13 06:57:42 2007
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: freebsd-ports@freebsd.org
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B6ED516A400
	for <freebsd-ports@freebsd.org>; Fri, 13 Apr 2007 06:57:42 +0000 (UTC)
	(envelope-from gerald@pfeifer.com)
Received: from vexpert.dbai.tuwien.ac.at (vexpert.dbai.tuwien.ac.at
	[128.131.111.2])
	by mx1.freebsd.org (Postfix) with ESMTP id 7A03113C448
	for <freebsd-ports@freebsd.org>; Fri, 13 Apr 2007 06:57:42 +0000 (UTC)
	(envelope-from gerald@pfeifer.com)
Received: from acrux.dbai.tuwien.ac.at (acrux [128.131.111.60])
	by vexpert.dbai.tuwien.ac.at (Postfix) with ESMTP id 2986A13791;
	Fri, 13 Apr 2007 08:30:24 +0200 (CEST)
Received: by acrux.dbai.tuwien.ac.at (Postfix, from userid 1203)
	id DA0C21A7C9; Fri, 13 Apr 2007 08:30:24 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by acrux.dbai.tuwien.ac.at (Postfix) with ESMTP id CA3BA1A7C7;
	Fri, 13 Apr 2007 08:30:24 +0200 (CEST)
Date: Fri, 13 Apr 2007 08:30:24 +0200 (CEST)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Rong-en Fan <grafan@gmail.com>
In-Reply-To: <6eb82e0704121003n30a209c5y25d8f64ba6b43eeb@mail.gmail.com>
Message-ID: <Pine.LNX.4.64.0704130820460.32062@acrux.dbai.tuwien.ac.at>
References: <461E1CC8.7090606@adestra.com>
	<200704121918.21307.andy@athame.co.uk>
	<6eb82e0704121003n30a209c5y25d8f64ba6b43eeb@mail.gmail.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Cc: Andy Fawcett <andy@athame.co.uk>, freebsd-ports@freebsd.org
Subject: Re: Generating INDEX
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Apr 2007 06:57:42 -0000

On Fri, 13 Apr 2007, Rong-en Fan wrote:
> I think it's because lang/gcc41, gcc42's usage of USE_GNOME is incorrect.
> It should be
> 
> WANT_GNOME= yes
> 
> .include <bsd.port.pre.mk>
> 
> USE_GNOME+=
> 
> And our INDEX builder is i386, so we don't see this.

Thanks for the report and the diagnosis.  I'm away from a machine where
I can do a reasonable FreeBSD test/commit.

Would the patch below address the issue?  If so, anybody feel free to
commit to the lang/gcc41 and lang/gcc42 ports!

(Now, there is a huge problem with this:  The idea behind the original 
changes was to use OPTIONS for these ports.  Alas OPTIONS are processed
in bsd.port.mk.pre so their WITH/WITHOUT settings are available only after 
bsd.port.mk.  If we have to define WANT_GNOME before bsd.port.mk.pre, the 
result of OPTIONS is not available yet.  Does this mean we cannot sensibly 
use OPTIONS for optional dependencies like this?)

Gerald

Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/lang/gcc41/Makefile,v
retrieving revision 1.318
diff -u -3 -p -r1.318 Makefile
--- Makefile	10 Apr 2007 05:24:27 -0000	1.318
+++ Makefile	13 Apr 2007 06:24:29 -0000
@@ -34,6 +34,9 @@ USE_BZIP2=	yes
 USE_GMAKE=	yes
 USE_ICONV=	yes
 USE_PERL5_BUILD=yes
+.if defined(WITH_JAVA_AWT)
+WANT_GNOME=	yes
+.endif
 
 PATCH_WRKSRC=	${SRCDIR}
 CONFIGURE_SCRIPT=	../${SRCDIR:C/${WRKDIR}//}/configure