From owner-cvs-src@FreeBSD.ORG Thu Mar 9 09:03:32 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AE30E16A420; Thu, 9 Mar 2006 09:03:32 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id E12BC43D45; Thu, 9 Mar 2006 09:03:31 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id k2993UNb010033; Thu, 9 Mar 2006 11:03:30 +0200 (EET) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ip.net.ua [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 77070-01; Thu, 9 Mar 2006 11:03:11 +0200 (EET) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id k2992qUe010014 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 9 Mar 2006 11:02:52 +0200 (EET) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.4/8.13.4) id k29937TP045600; Thu, 9 Mar 2006 11:03:07 +0200 (EET) (envelope-from ru) Date: Thu, 9 Mar 2006 11:03:07 +0200 From: Ruslan Ermilov To: Warner Losh Message-ID: <20060309090307.GK54826@ip.net.ua> References: <200603090133.k291XcfB005631@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hl1kWnBARzJiTscN" Content-Disposition: inline In-Reply-To: <200603090133.k291XcfB005631@repoman.freebsd.org> User-Agent: Mutt/1.5.11 X-Virus-Scanned: amavisd-new at ip.net.ua Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.README X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2006 09:03:32 -0000 --hl1kWnBARzJiTscN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 09, 2006 at 01:33:38AM +0000, Warner Losh wrote: > imp 2006-03-09 01:33:38 UTC >=20 > FreeBSD src repository >=20 > Modified files: > share/mk bsd.README=20 > Log: > Now that we now spell NO_MAN=3Dxxx MAN=3D, update the docs. > =20 > Submitted by: John Hein > =20 > Revision Changes Path > 1.30 +1 -1 src/share/mk/bsd.README >=20 I object. 1) This is not common: grep '^NO_MAN=3D' {bin,usr.bin,sbin,usr.sbin}/*/Makefile |wc -l 10 grep '^MAN=3D[[:space:]]*(#.*)?$' {bin,usr.bin,sbin,usr.sbin}/*/Makefile |w= c -l 0 2) MAN=3D is worse for performance (with NO_MAN, bsd.man.mk is not processes at all which is faster). 3) This is in contrast with NO_OBJ and similar knobs. I can only suggest to make it spell "NO_MAN=3D", i.e., without any value. Was there some discussion that I've missed? Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --hl1kWnBARzJiTscN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFED+9KqRfpzJluFF4RAgnBAJoD2V9l+X5tjwOocTLPPn0ScJV3/QCfSSGJ UqQ6RPhHjNOyfcss59hTiLw= =Gm6V -----END PGP SIGNATURE----- --hl1kWnBARzJiTscN--