From owner-svn-src-all@FreeBSD.ORG Mon Jan 6 17:37:43 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9828242E; Mon, 6 Jan 2014 17:37:43 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1CC67187D; Mon, 6 Jan 2014 17:37:42 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id s06HbcoH008076; Mon, 6 Jan 2014 19:37:38 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua s06HbcoH008076 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id s06Hbc9f008075; Mon, 6 Jan 2014 19:37:38 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 6 Jan 2014 19:37:38 +0200 From: Konstantin Belousov To: Adrian Chadd Subject: Re: svn commit: r260363 - head/sys/dev/ath Message-ID: <20140106173738.GG59496@kib.kiev.ua> References: <201401060348.s063mW8C031852@svn.freebsd.org> <20140106035139.GC59496@kib.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rH0ZJBuyEosIc0Vp" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Jan 2014 17:37:43 -0000 --rH0ZJBuyEosIc0Vp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 05, 2014 at 09:37:21PM -0800, Adrian Chadd wrote: > On 5 January 2014 19:51, Konstantin Belousov wrote: > > On Mon, Jan 06, 2014 at 03:48:32AM +0000, Adrian Chadd wrote: > >> Author: adrian > >> Date: Mon Jan 6 03:48:32 2014 > >> New Revision: 260363 > >> URL: http://svnweb.freebsd.org/changeset/base/260363 > >> > >> Log: > >> Correctly remove entries from the relevant receive ath_buf list befo= re > >> freeing them. > >> > >> The current code would walk the list and call the buffer free, which > >> didn't remove it from any lists before pushing it back on the free l= ist. > >> > >> Tested: AR9485, STA mode > >> > >> Noticed by: dillon@apollo.dragonflybsd.org > > This is a NOP, right ? >=20 > Nope. the previous version didn't remove the entries from the list. > that's the bug. Hm, you mean that the previous version did not TAILQ_INIT() after the loop ? Then I agree. --rH0ZJBuyEosIc0Vp Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJSyunhAAoJEJDCuSvBvK1BAc4P/A+wbYIbG11/iJf6045gbnLc ZRyLfcnNW7rMUC7NN5mKa6V3bIbG/R3XE0g+VHWSP/YDF1o67pU7+kMzlI4/JTzZ X1nRwgKm8gI4iGq/OfAgHeuQdXGosjT031iDMD+9bsNPjllQOZNFG5y6mEl0nS/9 42nhaYKwjg0n0bZs2seidnUbujkZTHtrWPeB81D9mhcz3xCU0l8XUxTC6pZFWt5d BkDhugI+DfqB8qU4TzBKt1LIsoQLUuxhPNimoX+5pJwTHF5N6Gu2BRtyK6i12Fnx rjZufZHTLokBysGnoLpfZxBpdFIq5egYrqoe9+Oinda7I6XoAwsQva+qftLs28ec j3385PevNI1+YkaUGXKdwyM3gxsyRvIJmZR3IYf7wQoywh7cv3CaewpXgoBhxP4G ZiH4zFDxcdP0GxR2L68QW6m/RAZKQkXetwdke709uOAFHtImYt2f7I8ffTZEOfCB IJOKhSgqL3sKm+5vCMQGzfVEzUkOR0N+7zCF11aXQZYmKp6Or31rovXdf2nIPTA9 F45dhXa/ZYGA0cj2RHWDbWTAoJgSibwH5j//SUKD/S8dCXyPFgF8NH02/qI5rQja R6q49giV+2ojWtohJX7AwTHpL2+v6ktMJixdYYNmtkfRHTeIv1BD5tvbajS8KJh9 UPdVP5IMXjA3CNFC7foX =6tUW -----END PGP SIGNATURE----- --rH0ZJBuyEosIc0Vp--