From owner-svn-src-all@FreeBSD.ORG Mon Feb 16 21:46:46 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BF84B9B0; Mon, 16 Feb 2015 21:46:46 +0000 (UTC) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 43AA26E5; Mon, 16 Feb 2015 21:46:45 +0000 (UTC) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t1GLkfwR056518 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 17 Feb 2015 00:46:41 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t1GLkfYB056517; Tue, 17 Feb 2015 00:46:41 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Tue, 17 Feb 2015 00:46:41 +0300 From: Gleb Smirnoff To: Craig Rodrigues Subject: Re: svn commit: r278858 - head/sys/net Message-ID: <20150216214641.GM15484@FreeBSD.org> References: <201502161806.t1GI6PZh058915@svn.freebsd.org> <20150216193154.GJ15484@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Brad Davis X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Feb 2015 21:46:46 -0000 On Mon, Feb 16, 2015 at 11:37:37AM -0800, Craig Rodrigues wrote: C> On Mon, Feb 16, 2015 at 11:31 AM, Gleb Smirnoff wrote: C> C> > On Mon, Feb 16, 2015 at 06:06:25PM +0000, Brad Davis wrote: C> > B> Author: brd (doc committer) C> > B> Date: Mon Feb 16 18:06:24 2015 C> > B> New Revision: 278858 C> > B> URL: https://svnweb.freebsd.org/changeset/base/278858 C> > B> C> > B> Log: C> > B> Fix build. C> > B> C> > B> Approved by: gibbs C> > C> > Thanks, Brad and Justin. My failure. C> C> I think it is hilarious that you criticized me for breaking the build in PF, C> and at *almost the same time*, you broke the build in PF. LOL! C> C> Hopefully, we can move on from this and get everyone's fixes in to help C> improve the PF code. The difference between our breakages is that I missed a file when listing files in 'svn commit', and you don't understand that blindly deleting kproc_exit() is a problem. -- Totus tuus, Glebius.