From nobody Mon Apr 27 22:00:37 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g4HYz1RpYz6Zjph; Mon, 27 Apr 2026 22:00:39 +0000 (UTC) (envelope-from markj@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g4HYz0L0Vz3glr; Mon, 27 Apr 2026 22:00:39 +0000 (UTC) (envelope-from markj@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777327239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LjtK3XwSiaQ6NROSDCcOyrRYcFFZcsF1TPqeI1GBKnc=; b=p0eRUIry+qU6D13FkKxrAbWP/7foBssySZBBtZS5Nke4CrUvk3ZIakB1UoCRnZu5wuYwG7 O0W1W2jhvQ2R56X4ChJ7WnuUKBopUhcuv+tqrWr4TcvsmQeB1gepffMSTl65xsLoTKtloe tpy6ugV/3JaxqJx+Qd1mImliat6QzIv16z/MsTu/UpPn/l35twl/vG17IXJnjwqa3YMAW9 GQZA1FBCUvFATqmX6e6sQojbsTeXHIkV0Fp8LaTId8q3g2SEa5RtyCigaVk9um94ZZYDTc OvTTs5bhNpeZYKsid6/6jJAMBHdb0BDTk166g7ElTdWoftfRXVThDinLzZ9JjA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777327239; a=rsa-sha256; cv=none; b=KNdMg+Y2ByOmccPqbnNize6qvwAMe8o0cxJnQ9T++uOi6xVNMF/8fN5zOnn12VK1jmUsap 3TPRuxfuulgrv03bFlcZgFydvcw/no9Vts57PZMPGnZesfKZHfLp9iPbDGG1WNlAqFRMfS RLPxXRD5sMHRCjYaBcwHztvm7q0rvNXybgQSheUPVEj/8F4MXu32Qf8P4xVYT6XOQr6+OT ZC4Mc1P6aQYI5LaVj2n/7xBWfsyaI6XlKIVrVelcN6zH8j2ZX+0XyyUr6RgtpT3DisJOKz iRoWDhGL89ODoxKvlhq++yisqRk8xY6MAtv7/X7CnI5NGu9J6WyYxm5Dbyh5DQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777327239; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LjtK3XwSiaQ6NROSDCcOyrRYcFFZcsF1TPqeI1GBKnc=; b=PDoMMGRkI40JJcRp22X9gvPR/9xXzVAGKNygM835bLe+ylPFL9mJKOEcf6u1vYxuYWif3E UGsp/aiRInsiJ0kKgnZYj5+iJrIyJ0OeGfbMMHlsimGo2FD8yxGXqutpYWSOOIbkMt1MNj oxXpmzGJ8ZoJTqAsrwGDE/KsY4180uwxLAsDB+lo1mOAZ/Kfv1C7BDGt4HEJD2AiGWay6J d4P47gLMF3zG/8QVdvcRauVG3ZCGRMnXL1aNB4nAZbVplqjRMTBU8fyJs7eKTbmNy89IWF qNx0Si19V+Vejy5SWzNnZQ/vhG1hE+OiMqZM0FYLyvK/HWwqcBFMy+OCl2OxXA== Received: from nuc (192-0-220-237.cpe.teksavvy.com [192.0.220.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: markj) by smtp.freebsd.org (Postfix) with ESMTPSA id 4g4HYy5GLlzpb; Mon, 27 Apr 2026 22:00:38 +0000 (UTC) (envelope-from markj@freebsd.org) Date: Mon, 27 Apr 2026 18:00:37 -0400 From: Mark Johnston To: Andrew Turner Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Sarah Walker Subject: Re: git: c16c95192f01 - main - virtio_net: Use bus_dma for rxq/txq buffers Message-ID: References: <69ef4acf.1fcd2.4d4d3e54@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69ef4acf.1fcd2.4d4d3e54@gitrepo.freebsd.org> On Mon, Apr 27, 2026 at 11:38:55AM +0000, Andrew Turner wrote: > The branch main has been updated by andrew: > > URL: https://cgit.FreeBSD.org/src/commit/?id=c16c95192f01237a876eb7bc336e3bbda9310171 > > commit c16c95192f01237a876eb7bc336e3bbda9310171 > Author: Sarah Walker > AuthorDate: 2026-02-16 14:19:13 +0000 > Commit: Andrew Turner > CommitDate: 2026-04-27 11:37:53 +0000 > > virtio_net: Use bus_dma for rxq/txq buffers > > While the majority of virtio platforms will be fully coherent, some may > require cache maintenance or other specific device memory handling (eg for > secure partitioning). Using bus_dma allows for these usecases. > > The virtio buffers are marked as coherent; this should ensure that sync > calls are no-ops in the common cases. > > Reviewed by: andrew > Sponsored by: Arm Ltd > Differential Revision: https://reviews.freebsd.org/D55492 After this commit I see a ton of warnings during boot in an amd64 bhyve VM: uma_zalloc_debug: zone "malloc-16" with the following non-sleepable locks held: exclusive sleep mutex vtnet0-rx0 (vtnet0-rx0) r = 0 (0xfffffe00f1e71d80) locked @ /home/markj/sb/main/src/sys/dev/virtio/network/if_vtnet.c:3584 exclusive sleep mutex vtnet0 (VTNET Core Lock) r = 0 (0xfffffe00f1b819a8) locked @ /home/markj/sb/main/src/sys/dev/virtio/network/if_vtnet.c:1572 stack backtrace: #0 0xffffffff8134b497 at witness_debugger+0x137 #1 0xffffffff8134dad9 at witness_warn+0x749 #2 0xffffffff819524bc at uma_zalloc_debug+0xbc #3 0xffffffff81951df0 at uma_zalloc_arg+0x30 #4 0xffffffff812083cb at malloc+0xab #5 0xffffffff8126f92c at sysctl_add_oid+0x7c #6 0xffffffff81b92fcd at alloc_bounce_zone+0x58d #7 0xffffffff81b91164 at bounce_bus_dmamap_create+0x294 #8 0xffffffff80ededc6 at vtnet_rx_alloc_buf+0x166 #9 0xffffffff80ee2ce2 at vtnet_init_locked+0xb42 #10 0xffffffff80ee10da at vtnet_ioctl+0x33a #11 0xffffffff814b63da at ifhwioctl+0x153a #12 0xffffffff814b81bb at ifioctl+0x76b #13 0xffffffff81356d36 at kern_ioctl+0x406 #14 0xffffffff8135687c at sys_ioctl+0x26c #15 0xffffffff81bffea5 at amd64_syscall+0x3d5 #16 0xffffffff81bb77fb at fast_syscall_common+0xf8 It seems surprising that we need to create a UMA zone at all.