From owner-svn-ports-all@FreeBSD.ORG  Sun Aug 17 19:38:44 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 8F22AF64;
 Sun, 17 Aug 2014 19:38:44 +0000 (UTC)
Received: from f10.opsec.eu (f10.opsec.eu [IPv6:2001:14f8:200:4::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 42F192705;
 Sun, 17 Aug 2014 19:38:44 +0000 (UTC)
Received: from pi by f10.opsec.eu with local (Exim 4.84 (FreeBSD))
 (envelope-from <pi@FreeBSD.org>)
 id 1XJ6Hm-000Foo-1k; Sun, 17 Aug 2014 21:38:38 +0200
Date: Sun, 17 Aug 2014 21:38:38 +0200
From: Kurt Jaeger <pi@FreeBSD.org>
To: Antoine Brodin <antoine@FreeBSD.org>
Subject: Re: svn commit: r365227 - head/Mk/Uses
Message-ID: <20140817193838.GO42528@f10.opsec.eu>
References: <201408171932.s7HJWIkV088586@svn.freebsd.org>
 <CAALwa8mFdvSQRPgPVntA4x+QMH2ceVOWQXB1KZiGHQEGA4M9gw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAALwa8mFdvSQRPgPVntA4x+QMH2ceVOWQXB1KZiGHQEGA4M9gw@mail.gmail.com>
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 Kurt Jaeger <pi@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Aug 2014 19:38:44 -0000

Hi!

> > Log:
> >   Mk/Uses/perl5.mk: Fix logic for removal of empty .bs files
[...]

> >  # Starting with perl 5.20, the empty bootstrap files are not installed any
> >  # more.  As we don't need them anyway, remove it altogether.
> > -.if ${PERL_LEVEL} < 502000
> > +.if ${PERL_LEVEL} >= 502000
> >  fix-perl-bs:
> >         -@${FIND} ${STAGEDIR} -name '*.bs' -size 0 -delete
> >  .endif
> 
> 
> This is totally wrong, please revert.

I had the case with devel/p5-File-Map that it still installs a
.bs in the STAGEDIR. So I searched on how to fix it and found this
please in Mk/Uses/perl5.mk and thought:

Isn't the logic the wrong way around ?

Please explain the logic behind the fix-perl-bs for ${PERL_LEVEL} >= 502000 ?

-- 
pi@FreeBSD.org         +49 171 3101372                6 years to go !