From owner-cvs-all  Mon Aug 20 23:46:54 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id A4E3537B405; Mon, 20 Aug 2001 23:46:47 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id QAA19815;
	Tue, 21 Aug 2001 16:46:45 +1000
Date: Tue, 21 Aug 2001 16:46:40 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@besplex.bde.org>
To: Ruslan Ermilov <ru@FreeBSD.org>
Cc: Mark Murray <markm@FreeBSD.org>, <cvs-committers@FreeBSD.org>,
	<cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/usr.bin/su su.c
In-Reply-To: <20010820192334.B83948@sunbay.com>
Message-ID: <20010821164246.J1960-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Mon, 20 Aug 2001, Ruslan Ermilov wrote:

> On Mon, Aug 20, 2001 at 05:46:11AM -0700, Mark Murray wrote:
> > markm       2001/08/20 05:46:11 PDT
> >
> >   Modified files:
> >     usr.bin/su           su.c
> >   Log:
> >   Very minor stylistic nit.
> >
> >   Discussed with:	ru
> >
> >   Revision  Changes    Path
> >   1.44      +2 -3      src/usr.bin/su/su.c

This seems to just add a style bug.  It removes a cast to void.  If casting
function return values to void is correct anywhere, then it is correct for
fprintf() to stderr.

> Yes, but please fix style(9) example then as well, so
> people don't do it wrong further.

The example in style(9) seems to be correct here.  (It is wrong later.
Using sysexits(3) is not normal style.)

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message