Date: Wed, 15 Apr 2020 17:28:13 +0200 From: "Kristof Provost" <kp@FreeBSD.org> To: "Olivier =?utf-8?q?Cochard-Labb=C3=A9?=" <olivier@freebsd.org> Cc: freebsd-testing@freebsd.org, freebsd-current <freebsd-current@freebsd.org>, Stable <freebsd-stable@freebsd.org>, bofh@freebsd.org, "Alexander V. Chernikov" <melifaro@freebsd.org> Subject: Re: FreeBSD CI Weekly Report 2020-04-12 Message-ID: <CBB8F199-5292-4AC6-90C5-53FADE0F04F7@FreeBSD.org> In-Reply-To: <CA%2Bq%2BTcr-B5dzPKV-DSiDYmcueXX=AFgh6%2Bj0G=-xJYB0XBzBpQ@mail.gmail.com> References: <20200414223710.GB33328@freefall.freebsd.org> <A2DF53A3-FD86-427D-B1EE-508228B0F4CE@FreeBSD.org> <DCC86D9B-ECF3-4393-B1C6-D76D1AE8BAC2@FreeBSD.org> <CA%2Bq%2BTcr-B5dzPKV-DSiDYmcueXX=AFgh6%2Bj0G=-xJYB0XBzBpQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15 Apr 2020, at 16:49, Olivier Cochard-Labbé wrote: > On Wed, Apr 15, 2020 at 4:10 PM Kristof Provost <kp@freebsd.org> > wrote: > >> >> The problem appears to be that >> /usr/local/lib/python3.7/site-packages/scapy/arch/unix.py is >> misparsing >> the `netstat -rnW` output. >> > > Shouldn't scapy use the libxo output of netstat to mitigate this > regression > ? That would likely help, yes. I’m going to leave that decision up to the maintainer, because I’m not going to do the work :) I’m also not sure how “stable” we want the netstat output to be. Best regards, Kristof From owner-freebsd-testing@freebsd.org Wed Apr 15 20:21:32 2020 Return-Path: <owner-freebsd-testing@freebsd.org> Delivered-To: freebsd-testing@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4467A2C1022; Wed, 15 Apr 2020 20:21:32 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from forward103o.mail.yandex.net (forward103o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::606]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 492YfK5H1Wz4Lyl; Wed, 15 Apr 2020 20:21:29 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from forward501o.mail.yandex.net (forward501o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::611]) by forward103o.mail.yandex.net (Yandex) with ESMTP id 4208D5F8320A; Wed, 15 Apr 2020 23:21:11 +0300 (MSK) Received: from mxback24o.mail.yandex.net (mxback24o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::75]) by forward501o.mail.yandex.net (Yandex) with ESMTP id 3EACF1E80002; Wed, 15 Apr 2020 23:21:11 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback24o.mail.yandex.net (mxback/Yandex) with ESMTP id DIwk9NYhfE-LA2S1Nra; Wed, 15 Apr 2020 23:21:10 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfw.ru; s=mail; t=1586982070; bh=pcnmyfi5q3HAMA53d7VJPHEH6EjFCQiuew2bY/lFFC8=; h=Message-Id:Cc:Subject:In-Reply-To:Date:References:To:From; b=cKmyl/jtOeyU7W0titJHlwzJpZoXtxvNdNC+PcrsWiw84mXhxbY4PhcnXFas3sUM0 hdfN1pj4ZFMHWU/2I4LZ9B/pWwFiwMbeRj0CIeN9vYSOumPm5e8S5X86FnqzQ2aWYc GA0fNVnuk6de2MIPE3itCUSd7V3zGnPVvUDvANEc= Received: by myt2-c3952fd46804.qloud-c.yandex.net with HTTP; Wed, 15 Apr 2020 23:21:10 +0300 From: Alexander V. Chernikov <melifaro@ipfw.ru> To: Kristof Provost <kp@freebsd.org>, "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org> Cc: "freebsd-current@freebsd.org" <freebsd-current@freebsd.org>, "freebsd-stable@freebsd.org" <freebsd-stable@freebsd.org>, "bofh@freebsd.org" <bofh@freebsd.org>, =?utf-8?B?T2xpdmllciBDb2NoYXJkLUxhYmLDqQ==?= <olivier@freebsd.org> In-Reply-To: <DCC86D9B-ECF3-4393-B1C6-D76D1AE8BAC2@FreeBSD.org> References: <20200414223710.GB33328@freefall.freebsd.org> <A2DF53A3-FD86-427D-B1EE-508228B0F4CE@FreeBSD.org> <DCC86D9B-ECF3-4393-B1C6-D76D1AE8BAC2@FreeBSD.org> Subject: Re: FreeBSD CI Weekly Report 2020-04-12 MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Wed, 15 Apr 2020 21:21:10 +0100 Message-Id: <885331586982061@myt5-bc0f9d8e5f27.qloud-c.yandex.net> Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 X-Rspamd-Queue-Id: 492YfK5H1Wz4Lyl X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ipfw.ru header.s=mail header.b=cKmyl/jt; dmarc=none; spf=pass (mx1.freebsd.org: domain of melifaro@ipfw.ru designates 2a02:6b8:0:1a2d::606 as permitted sender) smtp.mailfrom=melifaro@ipfw.ru X-Spamd-Result: default: False [-6.16 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; R_DKIM_ALLOW(-0.20)[ipfw.ru:s=mail]; RCVD_COUNT_FIVE(0.00)[5]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a02:6b8:0:1000::/52]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[ipfw.ru]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[6]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; DKIM_TRACE(0.00)[ipfw.ru:+]; RCVD_IN_DNSWL_NONE(0.00)[6.0.6.0.0.0.0.0.0.0.0.0.0.0.0.0.d.2.a.1.0.0.0.0.8.b.6.0.2.0.a.2.list.dnswl.org : 127.0.5.0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:13238, ipnet:2a02:6b8::/32, country:RU]; IP_SCORE(-3.66)[ip: (-9.72), ipnet: 2a02:6b8::/32(-4.76), asn: 13238(-3.85), country: RU(0.01)] X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Testing on FreeBSD <freebsd-testing.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-testing>, <mailto:freebsd-testing-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-testing/>; List-Post: <mailto:freebsd-testing@freebsd.org> List-Help: <mailto:freebsd-testing-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-testing>, <mailto:freebsd-testing-request@freebsd.org?subject=subscribe> X-List-Received-Date: Wed, 15 Apr 2020 20:21:32 -0000 15.04.2020, 15:10, "Kristof Provost" <kp@freebsd.org>: > On 15 Apr 2020, at 15:34, Kristof Provost wrote: >> On 15 Apr 2020, at 0:37, Li-Wen Hsu wrote: >>> (Please send the followup to freebsd-testing@ and note Reply-To is >>> set.) >>> >>> FreeBSD CI Weekly Report 2020-04-12 >>> =================================== >>> >>> Here is a summary of the FreeBSD Continuous Integration results for >>> the period >>> from 2020-04-06 to 2020-04-12. >>> >>> During this period, we have: >>> >>> * 1801 builds (94.0% (+0.4) passed, 6.0% (-0.4) failed) of buildworld >>> and >>> buildkernel (GENERIC and LINT) were executed on aarch64, amd64, >>> armv6, >>> armv7, i386, mips, mips64, powerpc, powerpc64, powerpcspe, riscv64, >>> sparc64 architectures for head, stable/12, stable/11 branches. >>> * 288 test runs (25.1% (-24.6) passed, 29.9% (+10.6) unstable, 45.1% >>> (+14.1) >>> exception) were executed on amd64, i386, riscv64 architectures for >>> head, >>> stable/12, stable/11 branches. >>> * 30 doc and www builds (83.3% (-1.3) passed, 16.7% (+1.3) failed) >>> >>> Test case status (on 2020-04-12 23:59): >>> | Branch/Architecture | Total | Pass | Fail | Skipped >>> | >>> | ------------------- | --------- | ---------- | -------- | -------- >>> | >>> | head/amd64 | 7744 (+4) | 7638 (+19) | 14 (+5) | 92 (-20) >>> | >>> | head/i386 | 7742 (+4) | 7628 (+15) | 16 (+5) | 98 (-16) >>> | >>> | 12-STABLE/amd64 | 7508 (0) | 7449 (-3) | 1 (+1) | 58 (+2) >>> | >>> | 12-STABLE/i386 | 7506 (0) | 7425 (-17) | 2 (+2) | 79 (+15) >>> | >>> | 11-STABLE/amd64 | 6882 (0) | 6829 (-6) | 1 (+1) | 52 (+5) >>> | >>> | 11-STABLE/i386 | 6880 (0) | 6749 (-82) | 80 (+80) | 51 (+2) >>> | >>> >>> (The statistics from experimental jobs are omitted) >>> >>> If any of the issues found by CI are in your area of interest or >>> expertise >>> please investigate the PRs listed below. >>> >>> The latest web version of this report is available at >>> https://hackmd.io/@FreeBSD-CI/report-20200412 and archive is >>> available at >>> https://hackmd.io/@FreeBSD-CI/ , any help is welcome. >>> >>> ## News >>> >>> * The test env now loads the required module for firewall tests. >>> >>> * New armv7 job is added (to replace armv6 one): >>> * FreeBSD-head-armv7-testvm >>> The images are available at https://artifact.ci.freebsd.org >>> FreeBSD-head-armv7-test is ready but needs test env update. >>> >>> ## Failing jobs >>> >>> * https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc6_build/ >>> * See console log for the error details. >>> >>> ## Failing tests >>> >>> * https://ci.freebsd.org/job/FreeBSD-head-amd64-test/ >>> * local.kyua.integration.cmd_about_test.topic__authors__installed >>> * sys.netipsec.tunnel.empty.v4 >>> * sys.netipsec.tunnel.empty.v6 >>> * sys.netpfil.common.forward.ipf_v4 >>> * sys.netpfil.common.forward.ipfw_v4 >>> * sys.netpfil.common.forward.pf_v4 >>> * sys.netpfil.common.tos.ipfw_tos >>> * sys.netpfil.common.tos.pf_tos >>> * sys.netpfil.pf.forward.v4 >> I can’t actually reproduce this failure in my test VM, but with the >> ci test VM I can reproduce the problem. >> It’s not related to pf, because the sanity check ping we do before >> we set up pf already fails. >> Or rather pft_ping.py sends an incorrect packet, because `ping` does >> get the packet to go where it’s supposed to go. >> >> Scapy seems to fail to find the source IP address, so we get this: >> >> 12:12:22.152652 IP 0.0.0.0 > 198.51.100.3: ICMP echo request, id 0, >> seq 0, length 12 >> >> I have a vague recollection that we’ve seem this problem before, but >> I can’t remember what we did about it. >> >> In all likelihood most of the other netpfil tests fail for exactly the >> same reason. > > The problem appears to be that > /usr/local/lib/python3.7/site-packages/scapy/arch/unix.py is misparsing > the `netstat -rnW` output. Thanks for the analysis! Sorry for breaking the tests. I should have run tests with userland changes installed. I'll revert the netstat output changes shortly to unbreak the tests. Re longer-term: parsing textual output for the routes does not seem to be a good habit, especially in these days. Structural (libxo) approach looks better, however I guess this will make scapy unusable on the routers with full-view. So far light-weight sysctl-route reader looks like the best option. What do you folks think? > > For reference, this is the output in the test VM: > > Routing tables > > Internet: > Destination Gateway Flags Nhop# Mtu Netif > Expire > 127.0.0.1 link#2 UH 1 16384 lo0 > 192.0.2.0/24 link#4 U 2 1500 epair0a > 192.0.2.1 link#4 UHS 1 16384 lo0 > 198.51.100.0/24 192.0.2.2 UGS 3 1500 epair0a > > Internet6: > Destination Gateway Flags > Nhop# Mtu Netif Expire > ::/96 ::1 UGRS > 4 16384 lo0 > ::1 link#2 UH > 1 16384 lo0 > ::ffff:0.0.0.0/96 ::1 UGRS > 4 16384 lo0 > fe80::/10 ::1 UGRS > 4 16384 lo0 > fe80::%lo0/64 link#2 U > 3 16384 lo0 > fe80::1%lo0 link#2 UHS > 2 16384 lo0 > fe80::%epair0a/64 link#4 U > 5 1500 epair0a > fe80::3d:9dff:fe7c:d70a%epair0a link#4 UHS > 1 16384 lo0 > fe80::%epair1a/64 link#6 U > 6 1500 epair1a > fe80::37:9eff:fe03:250a%epair1a link#6 UHS > 1 16384 lo0 > ff02::/16 ::1 UGRS > 4 16384 lo0 > > The parsing code seems to think that the netif for the 198.51.100.0/24 > route is 1500 rather than epair0a. > This may be related to the difference in netstat output, because on my > VM it looks like this: > > Routing tables > > Internet: > Destination Gateway Flags Use Mtu Netif > Expire > default 172.16.2.1 UGS 319 1500 vtnet0 > 127.0.0.1 link#2 UH 0 16384 lo0 > 172.16.2.0/24 link#1 U 14 1500 vtnet0 > 172.16.2.2 link#1 UHS 0 16384 lo0 > > Internet6: > Destination Gateway Flags > Use Mtu Netif Expire > ::/96 ::1 UGRS > 0 16384 lo0 > ::1 link#2 UH > 0 16384 lo0 > ::ffff:0.0.0.0/96 ::1 UGRS > 0 16384 lo0 > fe80::/10 ::1 UGRS > 0 16384 lo0 > fe80::%vtnet0/64 link#1 U > 0 1500 vtnet0 > fe80::5a9c:fcff:fe02:a95e%vtnet0 link#1 UHS > 0 16384 lo0 > fe80::%lo0/64 link#2 U > 0 16384 lo0 > fe80::1%lo0 link#2 UHS > 0 16384 lo0 > ff02::/16 ::1 UGRS > 0 16384 lo0 > > I suspect that this change was introduced in r359823 (Introduce nexthop > objects and new routing KPI). > > Best regards, > Kristof > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CBB8F199-5292-4AC6-90C5-53FADE0F04F7>