From owner-svn-src-head@FreeBSD.ORG  Thu Jun 24 12:07:54 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3C68E1065688;
	Thu, 24 Jun 2010 12:07:54 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 0C5708FC17;
	Thu, 24 Jun 2010 12:07:54 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id B339546B51;
	Thu, 24 Jun 2010 08:07:53 -0400 (EDT)
Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id EF3088A03C;
	Thu, 24 Jun 2010 08:07:52 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Juli Mallett <jmallett@freebsd.org>
Date: Thu, 24 Jun 2010 07:57:23 -0400
User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; )
References: <201006232326.o5NNQEtK011793@svn.freebsd.org>
	<20100623.202647.867924114552092597.imp@bsdimp.com>
	<AANLkTinYyrwpUpdfO8CUv7VuEROg3GZqmpXdHWm5nHgK@mail.gmail.com>
In-Reply-To: <AANLkTinYyrwpUpdfO8CUv7VuEROg3GZqmpXdHWm5nHgK@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201006240757.23510.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(bigwig.baldwin.cx); Thu, 24 Jun 2010 08:07:52 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham
	version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, xcllnt@mac.com,
	nwhitehorn@freebsd.org, svn-src-head@freebsd.org,
	"M. Warner Losh" <imp@bsdimp.com>
Subject: Re: svn commit: r209490 - head/sys/kern
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Jun 2010 12:07:54 -0000

On Wednesday 23 June 2010 10:56:46 pm Juli Mallett wrote:
> On Wed, Jun 23, 2010 at 19:26, M. Warner Losh <imp@bsdimp.com> wrote:
> 
> > : > #    define HZ 1000
> > : > #  else
> > : > #    define HZ 100
> >
> > Shouldn't this be defined in some file in ARCH/include instead?

Yes, machine/param.h should work just fine.  We could leave a default of 1000 
via the current #ifndef and just move the non-default settings into MD 
headers.

> Didn't it used to be?  I think the problem with doing that is that
> then someone inevitably writes code that uses HZ instead of the
> (tunable) hz.  Of course, you can hide it behind an obscure #ifdef and
> even give it an intimidating name.

No, it's been in subr_param.c since at least 4.4BSD.

-- 
John Baldwin