From owner-freebsd-ports-bugs@freebsd.org Tue Dec 6 08:44:18 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1F7CCC68B7F for ; Tue, 6 Dec 2016 08:44:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E9246F21 for ; Tue, 6 Dec 2016 08:44:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id uB68iHrw024948 for ; Tue, 6 Dec 2016 08:44:17 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 214184] audio/amarok-kde4: fails to build with ffmpeg 3.x Date: Tue, 06 Dec 2016 08:44:18 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa, patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rakuco@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kde@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Dec 2016 08:44:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D214184 Raphael Kubo da Costa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rakuco@FreeBSD.org --- Comment #9 from Raphael Kubo da Costa --- (In reply to matthew from comment #8) > I had thought MTP was not optional because there is no WITH_MTP switch in > the CMakeLists.txt as there is for the other options. There is, it's just added indirectly. Amarok's top-level CMakeLists.txt has this: macro_optional_find_package(Mtp) which is defined here: https://cgit.kde.org/kdelibs.git/tree/cmake/modules/MacroOptionalFindPackag= e.cmake?h=3DKDE%2F4.14 As the comment there says, "this macro is a combination of OPTION() and FIND_PACKAGE(), it works like FIND_PACKAGE(), but additionally it automatic= ally creates an option name WITH_, which can be disabled via the cmake GUI= or via -DWITH_=3DOFF", so WITH_Mtp should work as expected -- in fact, I= 've built the port on Poudriere with the MTP option disabled and the logs show src/core-impl/collections/mtpcollection is not being built and nothing is linking against libmtp. If you feel like something still needs to be patched, please file a new PR = so we don't mix FFMPEG 3 support with other adjustments to the port, especially now that this bug has already been closed. --=20 You are receiving this mail because: You are on the CC list for the bug.=