From owner-cvs-all@FreeBSD.ORG Sun May 6 15:52:49 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8DEC716A406 for ; Sun, 6 May 2007 15:52:49 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id F06BB13C459 for ; Sun, 6 May 2007 15:52:48 +0000 (UTC) (envelope-from andre@freebsd.org) Received: (qmail 15063 invoked from network); 6 May 2007 15:13:15 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 6 May 2007 15:13:15 -0000 Message-ID: <463DF9D6.4000004@freebsd.org> Date: Sun, 06 May 2007 17:52:54 +0200 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: Robert Watson References: <200705061516.l46FG6we030349@repoman.freebsd.org> <20070506162919.G24765@fledge.watson.org> In-Reply-To: <20070506162919.G24765@fledge.watson.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet tcp_input.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 May 2007 15:52:49 -0000 Robert Watson wrote: > > On Sun, 6 May 2007, Andre Oppermann wrote: > >> andre 2007-05-06 15:16:06 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/netinet tcp_input.c >> Log: >> Remove the defunct remains of the TCPS_TIME_WAIT cases from >> tcp_do_segment >> and change it to a void function. >> >> We use a compressed structure for TCPS_TIME_WAIT to save memory. Any >> late >> late segments arriving for such a connection is handled directly in >> the TW >> code. > > Since tcp_subr.c is such a catch-all, and quite long, I've was thinking > last night that we might want to move the tcp_tw* functions (and related > bits) into tcp_timewait.c. It could be that if we do that, since it > will be 99% post-Berkeley code, that we want to apply the > copyright/license from tcp_syncache.c, as jlemon did the timewait code > under the same contract as the syncache/syncookie work, but we should > check with him. Good idea. Will you check with him or shall I? -- Andre