From owner-freebsd-x11@freebsd.org Mon Feb 11 16:22:48 2019 Return-Path: Delivered-To: freebsd-x11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 99E3C14DBD68; Mon, 11 Feb 2019 16:22:48 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5477975506; Mon, 11 Feb 2019 16:22:46 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [176.74.212.121]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 5E732260446; Mon, 11 Feb 2019 17:22:44 +0100 (CET) Subject: Re: drm2 removed? To: sgk@troutmask.apl.washington.edu, freebsd-current@freebsd.org, freebsd-ports@freebsd.org, freebsd-x11@freebsd.org, Konstantin Belousov References: <20190211161205.GB41262@troutmask.apl.washington.edu> From: Hans Petter Selasky Message-ID: <42753ee1-008a-2c35-4319-37ebb1c4d0f1@selasky.org> Date: Mon, 11 Feb 2019 17:20:19 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190211161205.GB41262@troutmask.apl.washington.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5477975506 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 2a01:4f8:c17:6c4b::2 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-4.93 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[selasky.org]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[mail.turbocat.net]; NEURAL_HAM_SHORT(-0.91)[-0.905,0]; IP_SCORE(-2.72)[ip: (-8.90), ipnet: 2a01:4f8::/29(-2.41), asn: 24940(-2.26), country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Feb 2019 16:22:49 -0000 On 2/11/19 5:12 PM, Steve Kargl wrote: > Anyone have any idea which recent change broke the > drm-legacy-kmod port. This is why I raised an issue > with removal of drm2 from src/sys. How is suppose > to be fixed? > > > --- ttm_bo_manager.o --- > cc -O2 -pipe -march=core2 -fno-strict-aliasing -march=core2 -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I/usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/drm2/../src/ -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common -MD -MF.depend.ttm_bo_manager.o -MTttm_bo_manager.o -mno-mmx -mno-sse -msoft-float -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member -mno-aes -mno-avx -std=iso9899:1999 -c /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/src/dev/drm2/ttm/ttm_bo_manager.c -o ttm_bo_manager.o > --- ttm_bo.o --- > /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/src/dev/drm2/ttm/ttm_bo.c:1501:12: error: use of undeclared identifier 'NPGPTD' > 1, 0, VM_MAX_ADDRESS, PAGE_SIZE, 0, VM_MEMATTR_UNCACHEABLE); > ^ > ./machine/vmparam.h:173:31: note: expanded from macro 'VM_MAX_ADDRESS' > #define VM_MAX_ADDRESS VADDR(PTDPTDI, 0) > ^ > ./machine/pmap.h:122:19: note: expanded from macro 'PTDPTDI' > #define PTDPTDI (NPDEPTD - NTRPPTD - NPGPTD) > ^ > ./machine/param.h:98:19: note: expanded from macro 'NPDEPTD' > #define NPDEPTD (NBPTD / sizeof(pd_entry_t)) > ^ > ./machine/param.h:96:17: note: expanded from macro 'NBPTD' > #define NBPTD (NPGPTD << PAGE_SHIFT) > ^ > /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/src/dev/drm2/ttm/ttm_bo.c:1501:12: error: use of undeclared identifier 'pd_entry_t' > ./machine/vmparam.h:173:31: note: expanded from macro 'VM_MAX_ADDRESS' > #define VM_MAX_ADDRESS VADDR(PTDPTDI, 0) > ^ > ./machine/pmap.h:122:19: note: expanded from macro 'PTDPTDI' > #define PTDPTDI (NPDEPTD - NTRPPTD - NPGPTD) > ^ > ./machine/param.h:98:34: note: expanded from macro 'NPDEPTD' > #define NPDEPTD (NBPTD / sizeof(pd_entry_t)) > ^ > /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/src/dev/drm2/ttm/ttm_bo.c:1501:12: error: use of undeclared identifier 'NTRPPTD' > ./machine/vmparam.h:173:31: note: expanded from macro 'VM_MAX_ADDRESS' > #define VM_MAX_ADDRESS VADDR(PTDPTDI, 0) > ^ > ./machine/pmap.h:122:29: note: expanded from macro 'PTDPTDI' > #define PTDPTDI (NPDEPTD - NTRPPTD - NPGPTD) > ^ > /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/src/dev/drm2/ttm/ttm_bo.c:1501:12: error: use of undeclared identifier 'NPGPTD' > ./machine/vmparam.h:173:31: note: expanded from macro 'VM_MAX_ADDRESS' > #define VM_MAX_ADDRESS VADDR(PTDPTDI, 0) > ^ > ./machine/pmap.h:122:39: note: expanded from macro 'PTDPTDI' > #define PTDPTDI (NPDEPTD - NTRPPTD - NPGPTD) > ^ > /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/src/dev/drm2/ttm/ttm_bo.c:1505:10: error: use of undeclared identifier 'NPGPTD' > 0, VM_MAX_ADDRESS, PAGE_SIZE, 0)) { > ^ > ./machine/vmparam.h:173:31: note: expanded from macro 'VM_MAX_ADDRESS' > #define VM_MAX_ADDRESS VADDR(PTDPTDI, 0) > ^ > ./machine/pmap.h:122:19: note: expanded from macro 'PTDPTDI' > #define PTDPTDI (NPDEPTD - NTRPPTD - NPGPTD) > ^ > ./machine/param.h:98:19: note: expanded from macro 'NPDEPTD' > #define NPDEPTD (NBPTD / sizeof(pd_entry_t)) > ^ > ./machine/param.h:96:17: note: expanded from macro 'NBPTD' > #define NBPTD (NPGPTD << PAGE_SHIFT) > ^ > /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/src/dev/drm2/ttm/ttm_bo.c:1505:10: error: use of undeclared identifier 'pd_entry_t' > ./machine/vmparam.h:173:31: note: expanded from macro 'VM_MAX_ADDRESS' > #define VM_MAX_ADDRESS VADDR(PTDPTDI, 0) > ^ > ./machine/pmap.h:122:19: note: expanded from macro 'PTDPTDI' > #define PTDPTDI (NPDEPTD - NTRPPTD - NPGPTD) > ^ > ./machine/param.h:98:34: note: expanded from macro 'NPDEPTD' > #define NPDEPTD (NBPTD / sizeof(pd_entry_t)) > ^ > /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/src/dev/drm2/ttm/ttm_bo.c:1505:10: error: use of undeclared identifier 'NTRPPTD' > ./machine/vmparam.h:173:31: note: expanded from macro 'VM_MAX_ADDRESS' > #define VM_MAX_ADDRESS VADDR(PTDPTDI, 0) > ^ > ./machine/pmap.h:122:29: note: expanded from macro 'PTDPTDI' > #define PTDPTDI (NPDEPTD - NTRPPTD - NPGPTD) > ^ > /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/src/dev/drm2/ttm/ttm_bo.c:1505:10: error: use of undeclared identifier 'NPGPTD' > ./machine/vmparam.h:173:31: note: expanded from macro 'VM_MAX_ADDRESS' > #define VM_MAX_ADDRESS VADDR(PTDPTDI, 0) > ^ > ./machine/pmap.h:122:39: note: expanded from macro 'PTDPTDI' > #define PTDPTDI (NPDEPTD - NTRPPTD - NPGPTD) > ^ > 8 errors generated. > *** [ttm_bo.o] Error code 1 > > make[4]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/drm2/drm2 > 1 error > > make[4]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/drm2/drm2 > *** [all_subdir_drm2/drm2] Error code 2 > > make[3]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/drm2 > 1 error > > make[3]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058/drm2 > *** [all_subdir_drm2] Error code 2 > > make[2]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058 > 1 error > > make[2]: stopped in /usr/ports/graphics/drm-legacy-kmod/work/drm-legacy-50ea058 > ===> Compilation failed unexpectedly. > Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to > the maintainer. > *** Error code 1 > > Stop. > make[1]: stopped in /usr/ports/graphics/drm-legacy-kmod > *** Error code 1 > > Stop. > make: stopped in /usr/ports/graphics/drm-legacy-kmod > > ===>>> make build failed for graphics/drm-legacy-kmod > ===>>> Aborting update > > > ===>>> You can restart from the point of failure with this command line: > portmaster graphics/drm-legacy-kmod > > This command has been saved to /tmp/portmasterfail.txt > Hi, Looks like this commit removed the definitions you need: https://svnweb.freebsd.org/changeset/base/343567 --HPS