From nobody Wed Apr 12 13:43:43 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PxP7N19Dbz44nFV; Wed, 12 Apr 2023 13:43:44 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PxP7N0HZNz3pVR; Wed, 12 Apr 2023 13:43:44 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681307024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FV8e8BfkbxX2SFzCoHIHrUA5MmZOQm1da04oPh1Yrkg=; b=yso9akaWpjuTzUqbbPcxtrlysRPnt3+y83mhkaUNTihi5PszBhxt8AANLAiuyt3aPcnH7H Itf1O12zSGs1dorNLdh2q2Y3X/o7jS+rBblZBcW0f9ThlKKJyPUNWr15DZMDLkpzbGP0pv Z+Jk1nnLsQ6YAUUWbKKvoJV3HCDNJn671PrXUZXDW4zW1pULwsFr2iBazmr2jFegpePomD dSd4lQat3Jri2bFWYZbAJlTFA9qyAluEB6BGkR4U+Co2R/h8WbpYTISRlHS79lUH4ywZIB c417ItJloanaPCalC6P0V9LBFfU1YVZin5ag7BDi2/lqhMAvWD5zjfHecAXuAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681307024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FV8e8BfkbxX2SFzCoHIHrUA5MmZOQm1da04oPh1Yrkg=; b=OxjeX3pYnpU+UYn3b2nGBTrfgjKX2j1hFBQBIAQkMH+ei/T9Cr+FNoqJrI6X6wY7y5BWsJ Q/1aGoO5HhS0sZIChTd3tmolltrimIfmrj2OUR0gwFxFo7ZA/bzG1tvTOgaUS8GYcaOwZ3 fycccgQChBk32aVjUSEQ+ZxGFvdx7OUa++GU30u1++zwpusimD+qqpfnqDCtwVHNIFrNjK 1IVeVtKSu/Zo4FzMWlK4Z6dAYb59N10q9q/ckDduOlH7zx5kxIz8C1HYYr1vcOdU0zpjpK GxoxnYHdwL3PiL25AZVGnIPotqVV+Td9siDAGNWHwymlB0aa2BrZrEPy7p309A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681307024; a=rsa-sha256; cv=none; b=xr6cQmNdzOYCU0OayUqoRbCyzfy9rTS3mNCpT6Nz+ngBtqYdrUwlODl24t9ivtZUf8DBVd kYTl/S8Bq9Z2Yg1lJDpywO69nx5wm5eFMjBZUem5Jz346lZW5iesGXdd1L1Cx/lZ09XEqb 0B9LbPX1GTG688twzLVIF7U8QzvMt1eV5qIvBqo6x4SqQ+xEu5HPqFvcl5WpZeWKOexT7y uHy2dCQ8DQae5N3LWIQbFu5O+UVPNad2uyLGcmz0YqYxqwgHD5IchGqJwHUp/eSwQVmCKL Ig0lYoA7gTP+JyALnwPQWc3jBsrS4bR/pnG2mo4N8jxlMg/pOhiEbmFAXn8Lhw== Received: by freefall.freebsd.org (Postfix, from userid 1033) id E41CCF80D; Wed, 12 Apr 2023 13:43:43 +0000 (UTC) Date: Wed, 12 Apr 2023 13:43:43 +0000 From: Alexey Dokuchaev To: Muhammad Moinur Rahman Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: c89b6f279989 - main - lang/php8[12]: Fix build on aarch64 with ZTS Message-ID: References: <202304120539.33C5dOJA014331@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202304120539.33C5dOJA014331@gitrepo.freebsd.org> X-ThisMailContainsUnwantedMimeParts: N On Wed, Apr 12, 2023 at 05:39:24AM +0000, Muhammad Moinur Rahman wrote: > commit c89b6f2799891129e89d1b4fedf8e25865241060 > > lang/php8[12]: Fix build on aarch64 with ZTS > > - Refresh patches What good did it bring other than cloaking the actual fix with tons of needless, unrelated changes? You've poured a glass of honey into a bucket of tar. :( > PR: 266175 > Reported by: thresh@nginx.com That's pretty scarce description. PR was closed as non-actionable because you didn't have access to aarch64, until someone(tm) came along and pointed out the upstream commit that broke the build. You didn't describe the problem after that, you ignored most of the comments on that PR, including the one to reopen it, and of course you failed to give proper credit in the commit log. This is *not* how we do things in FreeBSD. ./danfe