Date: Wed, 12 Apr 2023 13:43:43 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Muhammad Moinur Rahman <bofh@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: c89b6f279989 - main - lang/php8[12]: Fix build on aarch64 with ZTS Message-ID: <ZDa1j/k5bMGxfDH0@FreeBSD.org> In-Reply-To: <202304120539.33C5dOJA014331@gitrepo.freebsd.org> References: <202304120539.33C5dOJA014331@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Apr 12, 2023 at 05:39:24AM +0000, Muhammad Moinur Rahman wrote: > commit c89b6f2799891129e89d1b4fedf8e25865241060 > > lang/php8[12]: Fix build on aarch64 with ZTS > > - Refresh patches What good did it bring other than cloaking the actual fix with tons of needless, unrelated changes? You've poured a glass of honey into a bucket of tar. :( > PR: 266175 > Reported by: thresh@nginx.com That's pretty scarce description. PR was closed as non-actionable because you didn't have access to aarch64, until someone(tm) came along and pointed out the upstream commit that broke the build. You didn't describe the problem after that, you ignored most of the comments on that PR, including the one to reopen it, and of course you failed to give proper credit in the commit log. This is *not* how we do things in FreeBSD. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZDa1j/k5bMGxfDH0>