From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Nov 6 15:50:02 2007 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7DE8416A46B for ; Tue, 6 Nov 2007 15:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 542D613C4CA for ; Tue, 6 Nov 2007 15:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id lA6Fo2sh043295 for ; Tue, 6 Nov 2007 15:50:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id lA6Fo2Hd043294; Tue, 6 Nov 2007 15:50:02 GMT (envelope-from gnats) Resent-Date: Tue, 6 Nov 2007 15:50:02 GMT Resent-Message-Id: <200711061550.lA6Fo2Hd043294@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Stephen Hurd Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4148916A468 for ; Tue, 6 Nov 2007 15:49:54 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 2B4C013C4B3 for ; Tue, 6 Nov 2007 15:49:54 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.1/8.14.1) with ESMTP id lA6Fne8Q021726 for ; Tue, 6 Nov 2007 15:49:40 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.1/8.14.1/Submit) id lA6FneX4021725; Tue, 6 Nov 2007 15:49:40 GMT (envelope-from nobody) Message-Id: <200711061549.lA6FneX4021725@www.freebsd.org> Date: Tue, 6 Nov 2007 15:49:40 GMT From: Stephen Hurd To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/117870: misc/xfce4-weather-plugin does not handle non-blocking connects() correctly X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2007 15:50:02 -0000 >Number: 117870 >Category: ports >Synopsis: misc/xfce4-weather-plugin does not handle non-blocking connects() correctly >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Nov 06 15:50:02 UTC 2007 >Closed-Date: >Last-Modified: >Originator: Stephen Hurd >Release: 6.2-RELEASE-p6 >Organization: >Environment: FreeBSD server.hurd.local 6.2-RELEASE-p6 FreeBSD 6.2-RELEASE-p6 #3: Tue Jul 24 22:03:03 PDT 2007 root@server.hurd.local:/usr/src/sys/i386/compile/SERVER i386 >Description: misc/xfce4-weather-plugin uses a nonblocking socket for the initial connect() but then later does not check that send() and recv() don't fail for ENOTCONN. As a result, this plugin only works on slow computers or computers with very fast internet connections. >How-To-Repeat: Configure misc/xfce4-weather-plugin. If necessary, slow your inetnet connection down (via dummynet for example). >Fix: Add attached patch to ports/misc/xfce4-weather-plugin/files Patch attached with submission follows: --- panel-plugin/weather-http.c.orig Wed Jan 17 10:02:39 2007 +++ panel-plugin/weather-http.c Tue Nov 6 07:33:04 2007 @@ -171,7 +171,7 @@ return FALSE; } } - else if (errno != EAGAIN) /* some other error happened */ + else if (errno != EAGAIN && errno != ENOTCONN) /* some other error happened */ { DBG ("file desc: %d", request->fd); @@ -239,7 +239,7 @@ callback (TRUE, request->cb_data); return FALSE; } - else if (errno != EAGAIN) + else if (errno != EAGAIN && errno != ENOTCONN) { perror ("keep_receiving()"); request->cb_function (FALSE, request->cb_data); >Release-Note: >Audit-Trail: >Unformatted: