From owner-svn-src-all@FreeBSD.ORG Tue Oct 15 15:00:24 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id DCC1F47D; Tue, 15 Oct 2013 15:00:23 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A403E2BC2; Tue, 15 Oct 2013 15:00:23 +0000 (UTC) Received: from smtp.fisglobal.com ([10.132.206.16]) by ltcfislmsgpa02.fnfis.com (8.14.5/8.14.5) with ESMTP id r9FF0HqH025686 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Tue, 15 Oct 2013 10:00:18 -0500 Received: from LTCFISWMSGMB21.FNFIS.com ([169.254.1.103]) by LTCFISWMSGHT05.FNFIS.com ([10.132.206.16]) with mapi id 14.02.0309.002; Tue, 15 Oct 2013 10:00:15 -0500 From: "Teske, Devin" To: Bryan Drewery Subject: Re: svn commit: r256343 - in head/usr.sbin/bsdinstall: . scripts Thread-Topic: svn commit: r256343 - in head/usr.sbin/bsdinstall: . scripts Thread-Index: AQHOybdAW1uGCLtcyE2zUcTOTrV8Ig== Date: Tue, 15 Oct 2013 15:00:14 +0000 Message-ID: <13CA24D6AB415D428143D44749F57D720FC6A04C@LTCFISWMSGMB21.FNFIS.com> References: <201310112041.r9BKfZeT002056@svn.freebsd.org> <20131015145032.GD98118@admin.xzibition.com> In-Reply-To: <20131015145032.GD98118@admin.xzibition.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.132.253.121] Content-Type: text/plain; charset="us-ascii" Content-ID: <56640DC77A0609499DA7FBB4253F8177@fisglobal.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.10.8794, 1.0.431, 0.0.0000 definitions=2013-10-15_05:2013-10-15,2013-10-15,1970-01-01 signatures=0 Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "Teske, Devin" , Allan Jude , "svn-src-head@freebsd.org" , Devin Teske X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Devin Teske List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Oct 2013 15:00:24 -0000 CC'ing Allan Jude for feedback (I didn't have a hand in the selection of those values) --=20 Devin On Oct 15, 2013, at 7:50 AM, Bryan Drewery wrote: > On Fri, Oct 11, 2013 at 08:41:35PM +0000, Devin Teske wrote: >> Author: dteske >> Date: Fri Oct 11 20:41:35 2013 >> New Revision: 256343 >> URL: http://svnweb.freebsd.org/changeset/base/256343 >>=20 >> Log: >> Add zfsboot module as an option for automatic configuration. Default is >> to run interactively but it can be scripted too (optinally completely >> non-interactive). Currently supports GELI and all ZFS vdev types. Also >> performs validation on selections/settings providing error messages if >> necessary, explaining (in plain language) what the issue is. Currently >> the auto partitioning of naked disks only supports GPT and MBR (VTOC8 >> pending for sparc64), so is only available for i386/amd64 install. >>=20 >> Submitted by: Allan Jude , myself >> Reviewed by: Allan Jude >> Approved by: re (glebius) >>=20 >> Added: >> head/usr.sbin/bsdinstall/scripts/zfsboot (contents, props changed) >> Modified: >> head/usr.sbin/bsdinstall/bsdinstall >> head/usr.sbin/bsdinstall/scripts/Makefile >> head/usr.sbin/bsdinstall/scripts/auto >> head/usr.sbin/bsdinstall/scripts/config >>=20 >> +# Should we use gnop(8) to configure a transparent mapping to 4K sector= s? >> +# >> +: ${ZFSBOOT_GNOP_4K_FORCE_ALIGN:=3D1} >=20 > I believe this trick is no longer needed after r254591. >=20 >> *** DIFF OUTPUT TRUNCATED AT 1000 LINES *** > ... >> +# Default name for the boot environment parent dataset >> +# >> +: ${ZFSBOOT_BEROOT_NAME:=3Dbootenv} > ... >> + # Set bootfs property >> + zpool set bootfs=3D"$poolname/$ZFSBOOT_BEROOT_NAME/$ZFSBOOT_BOOT= FS_NAME" \ >> + "$poolname" || return $FAILURE >=20 > Can you please make ZFSBOOT_BEROOT_NAME be ROOT by default? This is what > sysutils/beadm, OpenSolaris/Illumos beadm, and I believe PC-BSD all expect > and use as well. _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.